[JIRA] Commented: (CC-1022) [PATCH] Include label in subject of build failure email

    [ http://jira.public.thoughtworks.org/browse/CC-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_18960 ] 

Dan Rollo commented on CC-1022:
-------------------------------

Have you mentioned this on the user list?  If not, would you?

I'm curious to find out if anyone has concerns about such a change to the subject text (probably not, but it's worth posting to find out).

If there are not objections, could you also include a unit test patch for this change?

> [PATCH] Include label in subject of build failure email
> -------------------------------------------------------
>
>                 Key: CC-1022
>                 URL: http://jira.public.thoughtworks.org/browse/CC-1022
>             Project: CruiseControl
>          Issue Type: Improvement
>          Components: Core Application
>    Affects Versions: 2.8.4
>            Reporter: Quinn Styl
>   Original Estimate: 1 hour
>  Remaining Estimate: 1 hour
>
> If we have the build label, why not include it in the email subject of a failed build?  In our case, we're using the p4changelistlabelincrementer, so we have a label to report.
> --- EmailPublisher.java.284	2010-09-15 19:42:04.000000000 -0700
> +++ EmailPublisher.java	2010-12-10 16:05:49.000000000 -0800
> @@ -174,12 +174,14 @@
>              subjectLine.append(subjectPrefix).append(" ");
>          }
>          subjectLine.append(logHelper.getProjectName());
> -        if (logHelper.isBuildSuccessful()) {
> +    
> +        // we want the label whether the build passed or failed
>              final String label = logHelper.getLabel();
>              if (label.trim().length() > 0) {
>                  subjectLine.append(" ").append(logHelper.getLabel());
>              }
>  
> +        if (logHelper.isBuildSuccessful()) {
>              // Anytime the build is "fixed" the subjest line
>              // should read "fixed". It might confuse recipients...but
>              // it shouldn't

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.public.thoughtworks.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d