Re: Getting a Patch Included [CC-1009]

Take 2... my fault.

I was testing it on MacOSX, but indirectly using the example script below.

I tried it;
without a cc.pid
with an empty cc.pid
invalid pid in cc.pid
valid pid for bash in cc.pid

----
#!/usr/bin/env bash

## single instance per cc.pid
# 1) use ${CC_PID} is already defined
# 2) default ${PID} to -1 and attempt to read pid from ${CC_PID}
# 3) check ${PID} is not stale
if [ ! "${CC_PID}" ]; then
    CC_PID=cc.pid
fi
PID_INVALID="000000"
PID=${PID_INVALID}
if [ -f "${CC_PID}" ]; then
    PID=`head -1 ${CC_PID}`
    if [[ ${PID} != *[[:digit:]]*  ]]; then
        PID=${PID_INVALID}
    fi
fi
RUNNING=`ps -ef | grep "${PID}" | grep -v grep | grep bash | wc -l | sed "s|
||g"`
if [ "${RUNNING}" != "0" ]; then
    echo "CruiseControl already running"
    exit -1
fi

EXEC="echo hello"
echo $EXEC
$EXEC &
echo $! > ${CC_PID}
cat cc.pid
-----

John

On 19 December 2010 11:42, Dan Rollo <[email protected]> wrote:

> I was getting some odd errors when I tried to run some of the commands
> directly in a shell on Ubuntu. (Most likely due to my own mistakes).
> Just FMOI, what distro did you try the changes on?
>
> Thanks
> Dan
>
>
> On 12/19/2010 06:35 AM, Dan Rollo wrote:
> > Hi John,
> >
> > Posting the issue on the mailing list is the right thing to do.
> >
> > And yes, "committers pick them up as they are free."
> >
> > If it doesn't get picked up quickly, don't hesitate to nicely nag again
> > about it. ;)
> >
> > Dan
> >
> >
> > Message: 2
> > Date: Sun, 19 Dec 2010 08:47:23 +0000
> > From: John Patrick <[email protected]>
> > Subject: [Cruisecontrol-devel] Getting a Patch Included [CC-1009]
> > To: cruisecontrol-devel <[email protected]>
> > Message-ID:
> > <[email protected]>
> > Content-Type: text/plain; charset="utf-8"
> >
> > Hi,
> >
> > What is the process of getting a patch applied to subversion?
> >
> > I've created a patch that stops multiple instances of cruisecontrol using
> > the same ${CC_PID}, so effectively the same home directory.
> >
> > Who should I assign the issue to, or do committers pick them up as they
> are
> > free?
> >
> > John
>
>
>
> ------------------------------------------------------------------------------
> Lotusphere 2011
> Register now for Lotusphere 2011 and learn how
> to connect the dots, take your collaborative environment
> to the next level, and enter the era of Social Business.
> http://p.sf.net/sfu/lotusphere-d2d
> _______________________________________________
> Cruisecontrol-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/cruisecontrol-devel
>

------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d

_______________________________________________
Cruisecontrol-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/cruisecontrol-devel