Re: Test assumptions

Another issue: CruiseControlControllerTest calls TestUtil.getTargetDir(), which explicitly checks that the test is running out of a directory named "target."

That works with our current Ant build scripts, but it's pretty fragile.  I only noticed it because my IDE's default output directory isn't named target.  Looking at the commit message that introduced this check, however, it sounds like there was a good reason for doing this.

Dan - do you remember working on that?  Do you think all of those asserts are still necessary, or is it safe to drop them?  Did you actually encounter issues that would have been caught by those asserts, or were you just being extra careful?  If it's still necessary what do you think about relaxing the check to include a list of common directory names?  Or what about checking for the presence of some token in the root of the classpath directory, such as an empty this_properties_file_must_exist_for_all_tests.properties?


-----Original Message-----
From: "Kent R. Spillner" <[email protected]>
Sent: Wednesday, January 15, 2014 14:27
To: [email protected]
Subject: [Cruisecontrol-devel] Test assumptions

I'm setting up a new dev environment from scratch, and it's revealing a number of assumptions we've baked into our tests.

For example, NantBuilderTest#testBuildTimeout fails consistently in my IDE, but never fails from the command line.  I'm not familiar with the NantBuilder code, but I read through the Ant build tasks that are executed during command line builds and I don't see anything obvious like special properties or env variables or anything that would affect the execution of this test.

Does anyone know what special sauce is needed by the NantBuilderTest?  I'm sure I'm missing something really obvious.  :)


------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
Cruisecontrol-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/cruisecontrol-devel



------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk