Re: JSP reporting in 2.8.2 not displaying ISO 8601 dates correctly
Manfredo Hopp <[email protected]>
| Newsgroups | gmane.comp.java.cruise-control.user |
|---|---|
| Message-ID | <[email protected]> |
Sorry about my rush . There is another minor change in DateUtil.
In formatIso8601 I replaced the commented line by:
return ISO8601_DATE_FORMATTER.format(date);
// return DateUtils.format(date, DateUtils.ISO8601_DATETIME_PATTERN); mh
This corrects your observation abou status since.
I hope I dont find any more changes.
Manfredo Hopp
2009/2/27 Ron Hough <[email protected]>:
> Right... But when you make that change do you still get correct
> values on the main project status page of the JSP reporting app?
> Adjusting the zone on the date formatter in the DateUtil will indeed
> "fix" builddate as well as the date written to status.txt. However,
> when the JSP (specifically index.jsp) reads the date from status.txt
> and displays the "since" time in the "Status" column, the time is
> incorrect. It looks like the JSP was expecting UMT and is adjusting
> for local time, even though the time read in from status.txt was
> actually in local time already. (I don't see this happening
> explicitly, so I think it's something going on under the hood in the
> Java date classes...).
>
> On Feb 27, 2009, at 10:56 AM, Manfredo Hopp wrote:
>
>> In fact there was a minor change in my source which I had forgotten.
>> After running a diff I found in DateUtil the following line
>> commented out:
>> // ISO8601_DATE_FORMATTER.setTimeZone(TimeZone.getTimeZone("GMT
>> -0:00")); mh
>> So hopefully this should work for you.
>> Manfredo Hopp
>>
>>
>> 2009/2/26 Ron Hough <[email protected]>:
>>> Hm. That's an interesting observation. I didn't try building the
>>> entire project from source, although while attempting a fix I did
>>> rebuild the cruisecontrol.jar and replaced the one installed with the
>>> binary distribution. When I did that, I still got UTC times unless I
>>> did my own explicit conversion in the DateUtil code (which then
>>> messed up the JSP index page).
>>>
>>> On Feb 26, 2009, at 4:33 PM, Manfredo Hopp wrote:
>>>
>>>> Tested binary release vs compiled release (2.8.2) .
>>>> In binary release the Builddate in logs appears in UTC whereas in
>>>> compiled release Builddate is ok.
>>>>
>>>> Manfredo Hopp
>>>>
>>>>
>>>>>>>>> On Wed, Feb 18, 2009 at 4:59 PM, Ron Hough
>>>>>>>>> <[email protected]>
>>>>>>>>> wrote:
>>>>>>>>>> Hi, all...
>>>>>>>>>>
>>>>>>>>>> I updated CruiseControl from 2.7.2 to 2.8.2 (binary release),
>>>>>>>>>> and I'm
>>>>>>>>>> noticing that the JSP reporting tool is displaying "Date of
>>>>>>>>>> build:"
>>>>>>>>>> and "Last Changed:" dates in what looks like ISO 8601 format,
>>>>>>>>>> but not
>>>>>>>>>> converting for local time. In other words, I get something
>>>>>>>>>> like
>>>>>>>>>> "Date of build: 2009-02-18T23:26:16" which is the right
>>>>>>>>>> time in
>>>>>>>>>> UTC... but I'm in CST. This is the value being written to
>>>>>>>>>> the
>>>>>>>>>> log.xml for the build:
>>>>>>>>>> <info>
>>>>>>>>>> <property name="projectname" value="XXXXX" />
>>>>>>>>>> <property name="lastbuild" value="20090218171517" />
>>>>>>>>>> <property name="lastsuccessfulbuild"
>>>>>>>>>> value="20090218171517" />
>>>>>>>>>> <property name="builddate" value="2009-02-18T23:26:16" />
>>>>>>>>>> <property name="cctimestamp" value="20090218172616" />
>>>>>>>>>> <property name="label" value="build.3" />
>>>>>>>>>> <property name="interval" value="10" />
>>>>>>>>>> <property name="lastbuildsuccessful" value="true" />
>>>>>>>>>> <property name="logdir" value="XXXXX" />
>>>>>>>>>> <property name="logfile" value="log20090218172616Lbuild.
>>>>>>>>>> 3.xml" />
>>>>>>>>>> </info>
>>>>>>>>>>
>>>>>>>>>> Anyone know what's going on here? Is there a way to get this
>>>>>>>>>> time
>>>>>>>>>> stamp converted to local time when displayed?
>>>>>>>>>>
>>>>>>>>>> BTW, I'm using subversion (client rev. 1.4.4) for source
>>>>>>>>>> control.
>>>>>>>>>> Build server is running Fedora Core 8.
>>>>>>>>>>
>>>>>>>>>> Thanks...
>>>>>>>>>>
>>>>>>>>>> Ron
>>>>>>>>>>
>>>>>>>
>>>
>
> ------------------------------------------------------------------------------
> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
> -Strategies to boost innovation and cut costs with open source participation
> -Receive a $600 discount off the registration fee with the source code: SFAD
> http://p.sf.net/sfu/XcvMzF8H
> _______________________________________________
> Cruisecontrol-user mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/cruisecontrol-user
>
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H