Re: Fatal Error with missing modification set

Jeffrey

Thanks for the response.  I meant to mention also that we switch from version 2.4.1 to version 2.7.3 and that I do not remember having this issue with the older version.  So there must have been a code change in the config parsing between versions.

I will report as a bug but will first attempt a suggestion for a patch.  

Jeff 

-----Original Message-----
From: Jeffrey Fredrick [mailto:[email protected]] 
Sent: Wednesday, March 04, 2009 2:57 PM
To: [email protected]
Subject: Re: [Cruisecontrol-user] Fatal Error with missing modification set

Hi Jeff,

> It seems to me that the parsing should only fail if the document is 
> not well formed.  All other checks (like if a local working copy 
> exist) should not be performed until the project's build loop is run.

The problem with that approach is if you're configuring a nightly build and make a typo. You come in the next day and wonder why you don't have a build. That said I can imagine this particular check changing to being only at "runtime".

>  Is there somewhere in the configuration that I can change the 
> behavior of the parsing?  Should this be reported as a bug?

There's no switch right now.  You can report a bug but even better would be a patch.  ;)

Jtf

--
 Free hour of CI consulting: http://the.ci-guys.com


On Wed, Mar 4, 2009 at 9:55 AM, Meystrik,Jeff,ST LOUIS,Engineering
<[email protected]> wrote:
> Most of our projects are composed of many cvs tags inside the
> modificationset:
>
> <modificationset quietperiod="120">
>   <cvs localworkingcopy="projects/${project.name}/${project.dir}"
> tag="CARMA_6_10_0"/>
>   <cvs localworkingcopy="projects/${project.name}/NPPC Domain(II)"
> tag="CARMA_6_10_0"/>
>   <cvs localworkingcopy="projects/${project.name}/NPPC Common"
> tag="CARMA_6_10_0"/>
>   <cvs localworkingcopy="projects/${project.name}/Security"
> tag="CARMA_6_10_0"/>
> </modificationset>
>
> From time to time, the developers forget to tag a required project (example
> Security) and we receive the following error:
>
>    2009-03-02 14:12:12,164 [WrapperSimpleAppMain] FATAL Main   - Local
> working copy "projects/carma-6.10.0/Security" does not exist!
>
> Sporadically, this will cause CruiseControl to crash.  Also, CruiseControl
> will not restart until I either fix this problem or remove the project from
> the configuration file.  The problem with the restart is that it can not
> parse the config.xml file because of the missing required project:
>
> 2009-03-04 09:57:17,692 [Project build thread] ERROR CruiseControlController
> - error parsing config file C:\Program
> Files\Special\CruiseControl\projects\Build\cruise
> control\config.generated.xml
>
> net.sourceforge.cruisecontrol.CruiseControlException: Local working copy
> "projects/carma-6.10.0/Security" does not exist!
>
>         at
> net.sourceforge.cruisecontrol.util.ValidationHelper.fail(ValidationHelper.java:90)
>         at
> net.sourceforge.cruisecontrol.util.ValidationHelper.assertFalse(ValidationHelper.java:99)
>         at
> net.sourceforge.cruisecontrol.sourcecontrols.ConcurrentVersionsSystem.validate(ConcurrentVersionsSystem.java:447)
>
>         ...
>
> I have been running some test as I was typing this e-mail.  Looks like the
> problem I am seeing is in the failed parsing of the config.xml file.  (When
> the project's build loop runs, it correctly fails the build and reports the
> missing "Local working copy".)    It seems to me that the parsing should
> only fail if the document is not well formed.  All other checks (like if a
> local working copy exist) should not be performed until the project's build
> loop is run.  Is there somewhere in the configuration that I can change the
> behavior of the parsing?  Should this be reported as a bug?
>
> I did look on the issue tracking site and I found one issue (CCRB-27 don't
> crash the builder on build config errors ) that seemed similar to my issue.
> But there was not enough detail provide for me to determine if it was the
> same problem.
>
> Jeff Meystrik
>

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Cruisecontrol-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/cruisecontrol-user

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H