Re: updated BarracudaDiscRack! (please read)
Jacob Kjome <[email protected]>
| Newsgroups | gmane.comp.java.enhydra.barracuda.general |
|---|---|
| Message-ID | <[email protected]> |
Made a couple other changes to fix a few minor problems. Here is a copy of
changelog (note a follow-up question below...).....
Modified files:
BarracudaDiscRack/src/org/enhydra/barracuda/discRack/pres/screens/:
LoginScreen.java
RegistrationScreen.java
BarracudaDiscRack/src_mockups/discRack/: Edit.html Error.html
options.mappings
Log message:
Fixed null pointer exception in Registration screen. I think this
started happening since the way nulls are treated in the form mapping
changed slightly very recently. Also, made the exceptions that were thrown
deferred validation exceptions so that one error wouldn't mask all other
errors. Fixed link Error.html where I had to change the cased of "HREF" to
"href" and added an extra entry to the options.mappings file. Otherwise,
the error page didn't have a valid link back to the Login screen at runtime
because it still pointed to the Login.html file.
Changed the "CancelButton" in Edit.html to a type="button" from
type="submit", otherwise, the onSubmit of the form gets its onsubmit set to
onsubmit="this.Cancel.click();return false;". This doesn't seem to matter
when the cursor is focused in the text fields, as the first submit button
in the form gets automatically clicked, but when the checkbox has focus and
the <ENTER> key is hit, nothing gets automatically clicked and the onsubmit
takes action and dynamically clicks "Cancel" rather than the more
appropriate "Save Changes". Might need to rethink how the
HTMLActionRenderer decides which submit button to set for being clicked in
the onsubmit since right now, it just picks the last submit button in the
form. Should it be the first? Should we even guess at this?
Jake
A couple follow-up comments....
1. The first stuff about the null pointer exception occurring because the
code was counting on the old behavior of the form mapping code should be a
clue to anyone using form mapping to make sure to do testing of your
existing form mapping code when upgrading to the latest Barracuda because
some behavior has changed. Null form elements stay null instead of turning
into empty strings (I'm pretty sure that was the change, right?).
2. The second stuff about the behavior of HTMLActionRenderer should be
addressed. Currently, the HTMLActionRenderer adds code to dynamically
click the last button of type "submit" in the form in it's "onsubmit"
attribute. Obviously, this is problematic since it affected the behavior
of BarracudaDiscRack in a way that I had to apply a workaround of changing
the "Cancel" button to type "button" from type "submit" to make sure the
correct submit button gets dynamically clicked from the form's "onsubmit"
attribute. Should we use the first button on type "submit" in the form for
this instead of the last? Or should we guess at all? Comments?
Jake
At 12:26 AM 4/20/2003 -0500, you wrote:
>I've updated BarracudaDiscRack to work with the latest XMLC-2.2 and the
>latest Barracuda jars. It also has deferred parsing enabled so you can
>modify the .html files under the WEB-INF/classes directory in the same
>package as the XMLC classes and see your changes immediately.
>
>The docs may be a bit out of date. I haven't really checked them
>yet. Installation is quite simple. If you've been using
>"ant catalina-install" to install Barracuda to Tomcat, then you'll be
>happy to know you can do the same thing with BarracudaDiscRack. Just
>remember to set up a user which has access to the Tomcat manager app and
>then either modify build.properties in BarracudaDiscRack/src or, better
>yet, create a .build.properties in $user.home and add the information
>there. It will override the properties files that come with
>BarracudaDiscRack. Same goes for Barracuda and the contrib apps. No
>other mods are needed. It will just work :-)
>
>Jake
>
>_______________________________________________
>Barracuda mailing list
>[email protected]
>http://barracudamvc.org/lists/listinfo/barracuda