Re: testcases and release stuff...

Hi Stefan,

Did you update with the latest CVS source?  All testcases work where except 
for the known Thai locale errors.  I'm actually not sure we should be 
masking the errors.  We should, eventually, figure out how the Thai locales 
work with dates and support that....or not support it, but still not mask 
the errors.  We can just make a note that those two cases will have 4 
failures each with the Thai Locale.  It will be a known open issue.

Jake

At 09:22 AM 5/19/2003 +0200, you wrote:
>Hi Jake,
>
>you're right, it occurs in the Thai locales. Thai locale has a different
>years, they have a offset of 543, so the have now year 2546. I didn't
>manage to change the TestCases to run properly (because of the leap
>years), so I changed them not to use the Thai locale at all (see
>attached patch file).
>
>Another test fails:
>org.enhydra.barracuda.taskdefs.TestFileNames
>testPackageDirBuildFullBaseFileName
>Failure: Name 2 should be as expected expected:<......> but
>was:<...\...>
>
>This is related to XmlcUtils class, since this moved to the xmlc
>project, we should think about removing this test.
>
>Regards,
>Stefan
>
>Am Sam, 2003-05-17 um 08.32 schrieb Jacob Kjome:
> > Whoops, forget what I just said.  These probably are locale errors.
> > It is just that in the TestDateValidator, the error messages
> > explicitly state the locale that they failed in (Thai).  In
> > TestDateRangeValidator, the same basic stack trace occurs and the same
> > basic errors occur, but the locale is not provide in the error
> > message.  That's what confused me there.
> >
> > So, it looks like things probably are working as properly as they can
> > now, unless anyone else thinks they can fix the errors.  Otherwise,
> > Barracuda is pretty close to release.  I'll wait until Monday or so to
> > tag CVS.  So, report any oddities, errors, or anything else that looks
> > out of place so that we can get a solid 1.2.0 release of Barracuda out
> > early next week!!!
> >
> > Jake
> >
> > At 01:16 AM 5/17/2003 -0500, you wrote:
> >
> > > Ok, I did partially what you said.  I changed all 2003 dates to
> > > 2033.  I changed all 2004 dates to 2036 (because 2034 and 2035 both
> > > have 28 days, not 29).  Now I get only 4 errors in
> > > TestDateRangeValidator.  However, these errors have nothing
> > > whatsoever to do with the Thai locale as far as I can tell.  Two are
> > > reported as non-parseable dates even though they are correct (year
> > > 2000, month 2, day 29).  Nothing wrong with that date.  The other
> > > two errors are say that "1/1/2033 is not after Sat May 17 00:58:54
> > > CDT 2003".  This is quite clearly wrong.  This points to actual
> > > errors in DateRangeValidator rather than a problem with the
> > > testcase.
> > >
> > > I've checked in the basic changes needed to get the error count down
> > > to 4.  Now can one of the forms guru's check out DateRangeValidator
> > > to see what is wrong with it?
> > >
> > > thanks,
> > >
> > > Jake
> > >
> > > At 10:32 PM 5/16/2003 +0200, you wrote:
> > > > Hi,
> > > >
> > > > most of the 268 (264 to be precise) are related to the fixed date
> > > > 01/01/2003 inside the Testcase. 01/01/2003 is compared against the
> > > > current date, which is obviosly greater. When the Testcase was
> > > > created
> > > > in 2002 (or 2001?) it suceeded.
> > > > In general, unit test should not depend on any "moving target".
> > > >
> > > > Most failures could be solved by:
> > > > s/2003/2033/g and
> > > > s/2004/2034/g
> > > >
> > > > The other four failure occur while using the TH (thai?) locale. I
> > > > have
> > > > absolutly no idea why this happens...
> > > >
> > > > Regards,
> > > > Stefan
> > > >
> > > > Am Fre, 2003-05-16 um 17.08 schrieb Jacob Kjome:
> > > > > Why are there two TestExample classes that are, essentially,
> > > > identical
> > > > > but one is called "TestExample.java" in the o.e.b package and
> > > > the
> > > > > other is called TestExample2.java in the o.e.b.core package???
> > > > I
> > > > > would think that the latter could be removed.   Is that ok?
> > > > >
> > > > > I made some commits to cure some build problems with the
> > > > testcases.
> > > > > This was reported by Stefan Armbruster.  Thanks for that :-)
> > > > >
> > > > > We still have a problems with the
> > > > >
> > > > org.enhydra.barracuda.core.forms.validators.TestDateRangeValidator
> > > > and
> > > > >
> > > > theorg.enhydra.barracuda.core.forms.validators.TestDateValidatorwith
> > > > > 268 failures in the former and 4 failures in the latter.  If any
> > > > of
> > > > > you forms experts can look into this today, that would be great!
> > > > >
> > > > > We are getting very close to release.so please speak up if you
> > > > see
> > > > > problems in the latest CVS of Barracuda.  Also, if you think
> > > > certain
> > > > > parts of the docs need to be changed before release, make sure
> > > > you
> > > > > ping the list about this.  Again, patches are very welcome.
> > > > >
> > > > >
> > > > > Jake
> > > > --
> > > > Systemberatung & Softwareentwicklung
> > > > Stefan Armbruster        mail: [email protected]
> > > > Neithardtstr. 7          Tel.: +49 (89) 45670791
> > > > 85540 Haar               Fax.: +49 (89) 45670965
> > > >                          Mobil: +49 (163) 4711712
> > > > PGP Fingerprint: 3B80 C47A 2631 4253 52C9  3010 E096 1B9F B3BB
> > > > ADE8
> > > >
> > > > _______________________________________________
> > > > Barracuda mailing list
> > > > [email protected]
> > > > http://barracudamvc.org/lists/listinfo/barracuda
>--
>Systemberatung & Softwareentwicklung
>Stefan Armbruster        mail: [email protected]
>Neithardtstr. 7          Tel.: +49 (89) 45670791
>85540 Haar               Fax.: +49 (89) 45670965
>                          Mobil: +49 (163) 4711712
>PGP Fingerprint: 3B80 C47A 2631 4253 52C9  3010 E096 1B9F B3BB ADE8