RE: will commit unless I hear objections...

Hi Jake,

Well, not to be argumentative, but... ;-)

> I plan to change the name of DefaultDOMFactory.java to
> XMLCStdDOMFactory.java.

I'm happy with the current naming, but it you really want to do this, then I
think it should be changed to DefaultXMLCDOMFactory. The reason for this is
that everywhere we have a "default" implementation of an interface, it
always follows the naming convention of Default<interface name>, and if this
is going to be the default implementation for the XMLC DOM factory, then I
think it makes sense to use the name I suggested above.

> I am also tempted to do the same thing for the DefaultDOMWriter
> since it is XMLC specific.  The proposed name would be XMLCDOMWriter.

Once again, I'd prefer DefaultXMLCDOMWriter, for the same reason as given
above.

> Having a "default' doesn't really make must sense here because it
> isn't generic like, for instance, the DefaultDOMLoader is.

One other thing to mention is that even though there may not be multiple
XMLC factories/writers at this point, the whole point of interface is
allowing other implementations, so its always possible other ones might come
along. In which case, I think "Default" is still entirely appropriate.

> I propose adding the various specifyLocalEventInterests() and
> specifyLocalEventAliases() that DefaultEventGateway provides to
> the EventGateway interface.  That way, we wouldn't have to do the
> kludgy check for a specify implementation of EventGateway in
> DefaultApplicationAssembler.  Comments?

I'm not opposed to this.

Christian
----------------------------------------------
Christian Cryder [[email protected]]
Internet Architect, ATMReports.com
Barracuda - http://barracudamvc.org
----------------------------------------------
"Coffee? I could quit anytime, just not today"

> -----Original Message-----
> From: [email protected]
> [mailto:[email protected]]On Behalf Of Jacob Kjome
> Sent: Friday, May 30, 2003 12:30 PM
> To: BarracudaMVC Users List
> Subject: [Barracuda] will commit unless I hear objections...
>
>
>
> I plan to change the name of DefaultDOMFactory.java to
> XMLCStdDOMFactory.java.  I don't think this should cause any
> problems since
> nothing in Barracuda references DefaultDOMFactory, nor do I believe that
> anyone likely has referenced it themselves since, in the past, the
> DefaultDOMLoader used it by default and I doubt anyone changed
> that default.
>
> The reason for the change is that the implementations of
> DOMFactories are,
> well..., implementation-specific and it makes it much more clear
> as to what
> implementation is being used if the name of the class makes this
> obvious.  Having a "default' doesn't really make must sense here
> because it
> isn't generic like, for instance, the DefaultDOMLoader is.
>
>
> I am also tempted to do the same thing for the DefaultDOMWriter
> since it is
> XMLC specific.  The proposed name would be XMLCDOMWriter.  However, this
> change would be more problematic since there are lots of cases in
> Barracuda
> where DefaultDOMWriter is directly referenced and I imagine this
> is true of
> applications created by those in the Barracuda community.  So, I wouldn't
> make this particular change without the explicit "ok" of the community.
>
>
> One other thing.  Currently the DefaultApplicationAssembler does
> a check of
> whether a particular event gateway is an instance of DefaultEventGateway
> when evaluating the <event-interest> and <even-alias>
> configuration options
> in the assembly descriptor.  If it isn't, then it throws an
> exception.  This means that anyone who creates their own application
> assembler and supports specifying event interests and event alias' just
> like DefaultEventGateway, but doesn't extend DefaultEventGateway,
> will find
> that these configuration options are unavailable to them.  I
> propose adding
> the various specifyLocalEventInterests() and specifyLocalEventAliases()
> that DefaultEventGateway provides to the EventGateway interface.
> That way,
> we wouldn't have to do the kludgy check for a specify implementation of
> EventGateway in DefaultApplicationAssembler.  Comments?  Again, I
> wouldn't
> make this particular change without an explicit "ok" from the community.
>
> Jake
>
> _______________________________________________
> Barracuda mailing list
> [email protected]
> http://barracudamvc.org/lists/listinfo/barracuda