Re: New & Improved ObjectRepositoryAsxsembler

Hi Christian,

I tested out Diez' contrib example app with the new object repository 
assembler functionality (and commented out the <dom-loader> stuff in 
event-gateway.xml) and everything works great!  Nice job :-)

I saw how you modified the sax parser stuff.  That's pretty nice.  Since we 
no longer use the passed in parser, why not get rid of all the passing 
around of that stuff?  Also, I think we should separate the assembler from 
the servlet so that the assembler can be loaded via a servlet context 
listener.  Note that in order to keep "$this" working, you'll have to add a 
getServletContext() method to the assembler since it won't actually be a 
servlet anymore.  We can still have a servlet available to do the loadup 
for those using servlet 2.2, but for those using servlet 2.3, the servlet 
context listener is a much better way to do stuff like this.

Oh, and are the test variables necessary?  Shouldn't those types of things 
be in a unit test?  Just seems unnecessary to be in the actual working 
class.  Just takes up needless memory.

Anyway, great job.  This is now super useful!

Jake

At 08:27 PM 6/20/2003 -0600, you wrote:
>Ok folks, based on discussions from earlier today, I've just checked in a
>new and improved ObjectRepositoryAssembler. Here's the commit comments:
>
>--------------------------------
><b>csc_062003.1</b> - Pretty significant upgrade of
>ObjectRepositoryAssembler, per extensive  discussion on the email list.
><object> tag now supprts name='$this'; <method> tags can now return values,
>using the return="" attribute; and static methods on classes with no public
>constructors can now be invoked. In short, I think everything you want can
>now be done Jake :-)
>
>Note that I also upgraded the way we obtain an instance of the parser to
>follow the Sun convention (per Sun's JDK 1.4 and discussion with Shawn).
>Also note that the javadocs and comments in ObjectRepositoryAssembler are
>all up-to-date, and I have expanded the object repository.xml to better
>illustrate all the various possibilities. Finally, please notice that the
>test case (TestObjectRepositoryAssembler) has been improved to verify all
>the new funcitonality works. Woo hoo! Way cool! :-)
>--------------------------------
>
>Jake, you want to update from cvs and give it a shot? Anybody who wants to
>know more about the ObjectRepositoryAssembler, please take a look at the
>javadocs for this class in conjunction with the sample object-repository.xml
>that is found in WEB-INF.
>
>If you update from cvs, you are going to need to do a superclean in order to
>get the new and improved object-repository.xml...
>
>Questions or comments welcome...
>
>Christian
>----------------------------------------------
>Christian Cryder
>Internet Architect, ATMReports.com
>Project Chair, BarracudaMVC - http://barracudamvc.org
>----------------------------------------------
>"Coffee? I could quit anytime, just not today"
>
>_______________________________________________
>Barracuda mailing list
>[email protected]
>http://barracudamvc.org/lists/listinfo/barracuda