RE: Localize taskdef shouldn't compile
Jacob Kjome <[email protected]>
| Newsgroups | gmane.comp.java.enhydra.barracuda.general |
|---|---|
| Message-ID | <[email protected]> |
At 10:34 PM 9/9/2003 -0400, you wrote: >Jake, > > > I know this breaks backward compatibility, but this is the right way set > > things up. Let me know if anyone has concerns. It shouldn't be too hard > > to for people to update their builds. > >+1 for me on this...its a small change, easy to make, and if it improves >consistency then I'm all for it. Good call, IMO. Cool! >I will let Shawn review and then check in, since he's already familiar with >the issues... No need to. I committed everything already. You or Shawn might want to verify that the build works for you, but I'm pretty sure it does. Things work fine here at home. jake >Christian >---------------------------------------------- >Christian Cryder >Internet Architect, ATMReports.com >Project Chair, BarracudaMVC - http://barracudamvc.org >---------------------------------------------- >"Coffee? I could quit anytime, just not today" > > > > -----Original Message----- > > From: [email protected] > > [mailto:[email protected]]On Behalf Of Jacob Kjome > > Sent: Tuesday, September 09, 2003 7:08 PM > > To: [email protected] > > Subject: Re: [Barracuda] Localize taskdef shouldn't compile > > > > > > At 09:34 AM 9/9/2003 -0600, you wrote: > > >Sorry about missing the second part of your email, I think I just > > >completely read over it :). Anyways, you are right that the compilation > > >should probably be taken out of the events taskdef as well. I > > will work on > > >getting that change implemented today. > > > > If you haven't already implemented the change to the events taskdef, I've > > attached a patch that should do it. Note that I changed the "srcdir" > > parameter to "sourceout" to be consistent with other tasks and to better > > describe its purpose. Here is how to define the <events> task now... > > > > <events > > sourceout="${build.event_source.dir}" > > descriptor="${src.dir}/${src.package.path}${subdir}" > > /> > > > > > > I know this breaks backward compatibility, but this is the right way set > > things up. Let me know if anyone has concerns. It shouldn't be too hard > > to for people to update their builds. Make sure to add the sourceout > > directory to the list of things to compile in the "compile_rest" target > > (either colon-separated in the "srcdir" attribute or with nested <src > > path="..."/> elements). Note that I haven't checked this in yet. > > > > Jake > >_______________________________________________ >Barracuda mailing list >[email protected] >http://barracudamvc.org/lists/listinfo/barracuda