Re: @the project developer: minor improvements, tidy sourcecode

Yeah,

Been using IntelliJ IDEA the last 6 months. Cool IDE! ;)

It also picked up those little niggles. 
(Unused imports, variables declared but never used/variables set but
never used, etc)

Been meaning to ask Christian and Jake about those....

While we are on the topic of cleaning up the source code.
How about cleaning up all the commented out code?

I know Christian if an advocate of just keeping the code there so one
doesn't have to
dive into CVS to look at previous versions. I'm all for that. But for
classes that haven't changed at all
over the past year... I'd think it safe to clean out those
commented-out code.

Also,
I've noticed some cool java utilities out there that scan's java source
code against a set 
coding standard and then reports on which classes fail with a reason
etc etc.

Things like that will not only make for more readable code, but will
also make things easier for newbies who
dive into the Barracuda code.

Urrm.... Just some thoughts.

Regards
KD


>>> [email protected] 2003/11/19 21:43:02 >>>
Hi,

I've made some small improvements:

1. The thread in DefaultEventPool has now a name (useful inside
debugger to
identify threads).
2. ListValidator now validates any instance of java.util.List instead
of
only ArrayList before.

Since the changes do not alter specifications (ListValidator is
backward
compatible) it should be no risk to apply them to the CVS head. On the
attachement you will find the patches.

The second thing is a "bit" more extensive ;-)
First, some words about the background: I use Eclipse as my
development
environment. I configured the compiler settings to tell unused
imports,
never read variables, and so on. After I checked out the CVS head I
realized
that the sourcecode is full of unused imports (nearly any class), never
read
variables are here and there too. It would be around 5 clicks away to
tidy
this (Eclipse has a function "organize imports"). Also the unused
variables
could be comment out. But then I should have CVS commit rights to
update the
classes.
I would be very pleased if I'am welcome as a new contributor. If you
have
more questions on me before, feel free to ask. For the moment I can
tell
just two things: "the Servlet Spec is pasted one the inside of my
eyeballs"
(quote which I found on Jakarta site) but my english is not the best
because
it's not my mother tongue.


Regards,
Thorsten