RE: @the project developer: minor improvements, tidy sourcecode

These patches have been applied, along with an additional fix to
TemplateHelper!

<b>csc_112103_1</b> - Minor (but important) fix to TemplateHelper to make it
possible for multiple Set_Attr directives to be embedded in a single node
without stomping on one another. Also applied a couple of small patches to
DefaultEventPool (giving the cleanup thread a name) and to ListValidator
(making it work on List, not just ArrayList). Thanks to Thorsten Möller
[[email protected]] for providing the patches...

Thanks very much!

Christian
----------------------------------------------
Christian Cryder
Internet Architect, ATMReports.com
Project Chair, BarracudaMVC - http://barracudamvc.org
----------------------------------------------
"Coffee? I could quit anytime, just not today"


> -----Original Message-----
> From: [email protected]
> [mailto:[email protected]]On Behalf Of Thorsten Möller
> Sent: Wednesday, November 19, 2003 2:43 PM
> To: [email protected]
> Subject: [Barracuda] @the project developer: minor improvements, tidy
> sourcecode
>
>
> Hi,
>
> I've made some small improvements:
>
> 1. The thread in DefaultEventPool has now a name (useful inside
> debugger to
> identify threads).
> 2. ListValidator now validates any instance of java.util.List instead of
> only ArrayList before.
>
> Since the changes do not alter specifications (ListValidator is backward
> compatible) it should be no risk to apply them to the CVS head. On the
> attachement you will find the patches.
>
> The second thing is a "bit" more extensive ;-)
> First, some words about the background: I use Eclipse as my development
> environment. I configured the compiler settings to tell unused imports,
> never read variables, and so on. After I checked out the CVS head
> I realized
> that the sourcecode is full of unused imports (nearly any class),
> never read
> variables are here and there too. It would be around 5 clicks away to tidy
> this (Eclipse has a function "organize imports"). Also the unused
> variables
> could be comment out. But then I should have CVS commit rights to
> update the
> classes.
> I would be very pleased if I'am welcome as a new contributor. If you have
> more questions on me before, feel free to ask. For the moment I can tell
> just two things: "the Servlet Spec is pasted one the inside of my
> eyeballs"
> (quote which I found on Jakarta site) but my english is not the
> best because
> it's not my mother tongue.
>
>
> Regards,
> Thorsten
>