Re: patch for configuring event extension

Jacob Kjome <[email protected]> Mon, 12 Jan 2004 15:31:35 +0000
Newsgroups gmane.comp.java.enhydra.barracuda.general
Message-ID <[email protected]>
Quoting Thelmo Loisio <[email protected]>:

> With this small patch you can configure the event extension from a
> servlet init parameter.
> It seems to me very easy and straightforward, i think that people in a
> situation like mine could benefit from the flexibility of Barracuda even
> more.
> 
> Attached are unified diffs against current CVS.
> 
> --
> Thelmo


This is a nice idea, but I'm concerned that it collides with the
<servlet-mapping> configuration such as...

    <servlet-mapping>
        <servlet-name>ApplicationGateway</servlet-name>
        <url-pattern>*.event</url-pattern>
    </servlet-mapping>

If I have the above and then have...

    <init-param>
        <param-name>EventExtension</param-name>
        <param-value>.foo</param-value>
    </init-param>

What is the proper event extension; ".foo" or ".event"?  We really need to fall
in line with the servlet spec here.  Let's not create our own configuration
mechnanisms.  I don't have time at the moment to think about this much more, so
I will discuss this more later.  The one thing I know is that changing the even
extension should happen differently than what this patch proposes (Even though I
realize that this isn't really changing the way Barracuda has always done this,
it just providing a configuration option for it...but I think it needs to be
discouraged in support of a more standard way to doing things).

Jake