Re: latest commit...

Jacob Kjome wrote:

> BTW, I will be gone on vacation for the week, so when you don't hear 
> from me, that's why.
>
No sweat. Thanks for the update...

> Jake
>
> At 12:15 AM 3/12/2005 -0600, you wrote:
> >Hi Christian, I have a couple of issues with the latest commit...
> >
> >              public static void logRequestDetails(Logger l, Priority 
> priority)
> >
> >This should be...
> >
> >public static void logRequestDetails(Logger l, Level level)
> >
> >Priority should not be used just as Category should not be used.  
> Both may
> >cease to exist in future versions of Log4j (after 1.3).  See...
> >http://www.qos.ch/logging/preparingFor13.jsp
> >
> >
> >                As an additional note, ApplicationGateway has been 
> modified
> >to always reset the Log4j
> >                NDC and MDC context information after each req/resp 
> cycle.
> >This means that your application
> >                code can put stuff into the NDC context and not have to
> >worry about taking it out. As an
> >                example, if you have an AuthEvent handler (to make 
> sure the
> >user is logged in, you can simply
> >                do this:
> >
> >                     NDC.push("[User:"+username+"]");
> >
> >                and then the specific user that is logged in will 
> show in
> >the log descr string, FOR THE REST
> >                OF BOTH CONTROL AND VIEW HANDLER LOGGING (if you don't
> >understand why this is useful, email the
> >                list and ask).
> >
> >
> >Well, this sort of thing should be done in a servlet filter.  What if I
> >have a filter that wants to use NDC?  I push stuff on before the request
> >and I might even want do a bit after the request.  However, Barracuda 
> has
> >already cleared it.  Even if this is harmless (I have to confess, I 
> don't
> >use NDC or MDC much so I can't remember if this would be harmful or 
> not?),
> >stuff like this should not be done in the framework by default.  It is
> >above an beyond the responsibility of the framework.  The exception 
> to this
> >is the case where it can be configured, such as by choosing to add or
> >remove a servlet filter definition from web.xml.  I strongly suggest 
> this
> >be taken out of Barracuda's core and put into an optional servlet 
> filter,
> >maybe existing somewhere in the plankton package.
> >
> >BTW, has anyone taken a look at the forms package to see why both 
> Diez' and
> >Stefan's app's break (see my messages eariler on the list for
> >details)?  These were certainly working a while back.
> >
> >
> >Jake
> >
> >
> >
> >
> >--
> >Barracuda mailing list
> >[email protected]
> >http://www.objectweb.org/wws/lists/projects/barracuda
>
>
>------------------------------------------------------------------------
>
>
>--
>Barracuda mailing list
>[email protected]
>http://www.objectweb.org/wws/lists/projects/barracuda
>  
>


-- 

Christian

------------------------------------------------------------------------
Christian Cryder
Internet Architect, ATMReports.com <http://atmreports.com>
------------------------------------------------------------------------

/"Coffee? I could quit anytime, just not today"
http://seelifedifferently.blogspot.com/