Re: Barracuda still doesn't compile on JDK 1.3.1

Diez,

Thanks for taking the initiative to get this patched. I'm sorry I hadn't 
gotten around to it yet... just so many things on the plate right now 
:(. Anyways, I actually didn't have a need for this functionality in any 
app of mine, it was something Christian requested that I coded for him, 
so if this affects anyone it might be Christian.

Christian: does this break anything for you?

One of the things I had started to do (but haven't finished yet) was to 
get jdk1.3 on the server so that we can actually test compiles under 
both (or multiple) versions of the JDK. I think this would allow us to 
avoid this in the future and then we can at least guarantee that 
Barracuda compiles under versions X, Y, and Z of the JDK. We could even 
run the test cases for each version too. Hopefully I can get easy 
support for multiple compilers/vm's on the server by the end of the 
week, but I don't think it would actually be important until we get the 
daily automated build process figured out.

-shawn

Diez B. Roggisch wrote:
> Hi,
> 
> I just created a patch that makes barracuda compile with 1.3.1.
> 
> It covers two subjects:
> 
> HttpRequester:
> 
> It looks like the 1.4 api introduces some convenience methods, but reproducing 
> the same results is possible for 1.3.
> 
> HttpServices:
> 
> The ParseException now misses the initCause - well, whilst this surely eases 
> debugging, I don't consider it a major drawback if we lose this feature.
> 
> I havn't had the time to test it - I would love to get some feedback on this 
> by somebody actually using cookies (I never use them).
> 
> Maybe Shawn can test it, as he had the need for making the changes and can 
> check if the patch breaks his app?
> 
> Now that I can compile, I hope I find the time to move some of my contrib 
> classes to core.
> 
> Diez
> 
> 
> ------------------------------------------------------------------------
> 
> Index: org/enhydra/barracuda/plankton/http/HttpRequester.java
> ===================================================================
> RCS file: /u/cvs/Projects/EnhydraOrg/toolsTech/Barracuda/src/org/enhydra/barracuda/plankton/http/HttpRequester.java,v
> retrieving revision 1.2
> diff -r1.2 HttpRequester.java
> 496c496,505
> <         List scookies = (List) conn.getHeaderFields().get("Set-Cookie");
> ---
> 
>>        // dbr_032601.start
>>        //List scookies = (List) conn.getHeaderFields().get("Set-Cookie");
>>        List scookies = new ArrayList();
>>        for(int i = 0; conn.getHeaderFieldKey(i) != null; i++) {
>>            if("Set-Cookie".equals(conn.getHeaderFieldKey(i))) {
>>                scookies.add(conn.getHeaderField(i));
>>            }
>>        }
>>        // dbr_032601.end
> 
> 661c670
> < }
> \ No newline at end of file
> ---
> 
>>}
> 
> Index: org/enhydra/barracuda/plankton/http/HttpServices.java
> ===================================================================
> RCS file: /u/cvs/Projects/EnhydraOrg/toolsTech/Barracuda/src/org/enhydra/barracuda/plankton/http/HttpServices.java,v
> retrieving revision 1.2
> diff -r1.2 HttpServices.java
> 88c88,90
> <                         ee.initCause(e);
> ---
> 
>>                        // dbr_032601
>>                        // The 1.3 api doesn't support this
>>                        // ee.initCause(e);
> 
> 97c99,101
> <                         ee.initCause(e);
> ---
> 
>>                        // dbr_032601
>>                        // The 1.3 api doesn't support this
>>                        // ee.initCause(e);
> 
> 105c109,111
> <                         ee.initCause(e);
> ---
> 
>>                        // dbr_032601
>>                        // The 1.3 api doesn't support this
>>                        // ee.initCause(e);
> 
>