Re: my delta to your code

Bogdan Onoiu wrote:

> I commented all my changes. They all start with my name.
> Please note that some changes I've done are done just because that's the
> way I could go further in my project here. Please read them and confirm.

Hi Bogdan,

I am sorry for the long delay. Thanks a lot for your fixes. Would you 
mind subscribing to the kxml.enhydra.org list? This way, design 
decisions and discussions would be automatically archived in the mailing 
list, and others could participate if interested...?

Concerning your changes:

Issue #1: Codepage switch Event bug

Would it be OK to just let the codepage switch go silently without 
generating an event that is observable by the user? I think it would be 
consistent with the serializer where the codepages are also switched 
implictily...

Issue #2: +0x(8)5 offsets in the tables

0..4 and 0x80..0x85 cannot be used, and in J2ME every byte counts, so I 
decided to save the space. It may look a bit odd but I think it is 
sufficiently commented to avoid errors?

Issue #3: Lack of utf8 support (iso8859-1 is hardcoded)

I think the best solution would be to support the charset parameter of 
setInput. However, there are probably byte/char conversion issues 
lurking in the code... :-/

Issue #4: Attribute Start recognition, regular text lookup in the string 
table...

I am not sure how to do this best without lots of O(n) iterations....


Best,
Stefan