RE: xmlc's xerces and existing endorsed packages proposal....
Jacob Kjome <[email protected]>
| Newsgroups | gmane.comp.java.enhydra.xmlc |
|---|---|
| Message-ID | <[email protected]> |
Ug, ok, this looks like a problem with the html dom interfaces that come with Xerces2. They are supposed to have setSelected()...especially since the html dom recommendation java language binding for HTMLOptionElement has that method... http://www.w3.org/TR/2003/REC-DOM-Level-2-HTML-20030109/java-binding.html I'm doing some investigation to see what's going on here. Maybe we can just include the w3c recommendation html dom binding sources along with the new xmlc-all-runtime.jar file? Anyway, I'll report back. If anyone has a better idea what is up here, let me know. Anyway, I"ll be backing out my latest change. I should have thought about it more in the first place. Jake At 04:17 PM 5/19/2003 -0500, you wrote: >Just wanted to note that I had to make one minor change in the XHTML >package. I didn't notice it until I started using Jikes for compilation >(not sure why?), but sure enough, there is a difference between the >org.w3c.dom.html.HTMLOptionElement in the old api that came with Xerces1 >and the new api that comes with Xerces2. Here's the error.... > >compile: > [mkdir] Created dir: > D:\myclasses\Repository\Enhydra\XMLC_DSF_2003-05-19\xmlc\xmlc\modules\xhtml\build\classes > [javac] Compiling 178 source files to > D:\myclasses\Repository\Enhydra\XMLC_DSF_2003-05-19\xmlc\xmlc\modules\xhtml\build\classes > [javac] Found 1 semantic error compiling > "D:/myclasses/Repository/Enhydra/XMLC_DSF_2003-05-19/xmlc/xmlc/modules/xhtml/src/org/enhydra/xml/xhtml/dom/xerces/XHTMLSelectElementImpl.java": > [javac] 265. ( (HTMLOptionElement) options.item( i ) > ).setSelected( i == selectedIndex ); > [javac] > ^-------------------------------------------------------------------------^ > [javac] *** Semantic Error: No method named "setSelected" was found > in type "org.w3c.dom.html.HTMLOptionElement". > > >As it turns out, setSelected(boolean) was change to >setDefaultSelected(boolean). > >The good news is that was the only change I had to make to get everything >to compile properly under Jikes. Now if someone can tell me why javac >couldn't catch this bug Jikes could, that would be very helpful. > >Jake > >At 11:38 AM 5/19/2003 -0500, you wrote: > >>Please read follow-up emails. David misconstrued what I had said as a >>dependency upon j2sdk1.4.x. Let me make this perfectly clear. There is >>*no* dependency whatsoever upon j2sdk1.4.x. All this change does is make >>it so that XMLC will require some external jar to contain the JAXP >>resources, org.xml.*, and org.w3c.dom.* packages. Xerces2 and its >>xmlParserAPIs.jar fits the bill for this quite nicely. Use it with any >>JDK you want. Note that it also avoids version collisions of these >>various packages. There is *no* downside here. >> >>Jake >> >>At 11:10 AM 5/19/2003 -0500, you wrote: >>>I'd have a real problem with forcing JDK 1.4 as the minimum requirement >>>for XMLC. My application server (IBM WebSphere) currently only supports >>>JDK 1.3 -- really IBM's own implementation of Java 1.3. It sounds like I >>>wouldn't be able to use future releases of XMLC anymore? >>> >>> > -----Original Message----- >>> > From: David Li [mailto:[email protected]] >>> > Sent: Monday, May 19, 2003 12:15 AM >>> > To: [email protected] >>> > Subject: Re: Xmlc: xmlc's xerces and existing endorsed packages >>> > proposal.... >>> > >>> > >>> > I think the packages are needed for those using JDK 1.3 >>> > either to build >>> > or use XMLC. >>> > >>> > However, other then that, I don't see a problem removing the standard >>> > endorsed packages from XMLC. Actually, it's a good idea as the first >>> > step to move XMLC to more standard DOM interface. non-standard DOM >>> > interface dependency was one of the problem with XMLC. >>> > >>> > If it's OK to force JDK 1.4 as the minimum requirement for XMLC, I'd >>> > say go ahead with the change. >>> > >>> > David >>> > >>> > >>> > >>> > On Monday, May 19, 2003, at 12:36 Asia/Shanghai, Jacob Kjome wrote: >>> > >>> > > >>> > > I was wondering if anyone has a problem with the following >>> > proposal... >>> > > >>> > > I tested building XMLC after removing the endorsed packages (eg... >>> > > javax.xml.*, org.w3c.dom.*, org.xml.* packages) with xercesImpl.jar >>> > > (Xerces2 Implementation) + xml-apis.jar or xmlParserAPIs.jar >>> > > (containing endorsed packages) in An'ts ANT_HOME/lib. It >>> > built just >>> > > fine. I then ran the tomcat demo (with xercesImpl.jar and >>> > > xmlParserAPIs.jar in CATALINA_HOME/common/endorsed) and everything >>> > > worked perfectly. >>> > > >>> > > So, I propose that we remove the endorsed packages from >>> > XMLC's version >>> > > of Xerces. Other than removing the endorsed packages from >>> > the xerces >>> > > module, the only other thing needed is to comment out the >>> > place in the >>> > > build.xml where the "services" are added to the META-INF >>> > directory of >>> > > the generated xerces.jar file. >>> > > >>> > > This leaves us with only the XMLC-modified Xerces implementation >>> > > packages under org.enhydra.apache.* and makes it so that putting >>> > > XMLC's xerces.jar in WEB-INF/lib doesn't violate the >>> > servlet spec and >>> > > sun classloading spec which state that endorsed package are >>> > not to be >>> > > added to the added/loaded to/from the WebappClassLoader/child >>> > > classloader. Granted, In many cases, this isn't too much >>> > of an issue >>> > > as the container will simply refused to load certain package from >>> > > certain classloaders, but this issues caused many bugs in >>> > the 4.0.xx >>> > > versions of Tomcat and very well may continue to cause >>> > subtle errors >>> > > in Tomcat-4.1.xx and 5.0.xx. Plus, it doesn't seem to >>> > affect XMLC one >>> > > way or the other and removing them just makes things more correct. >>> > > Plus it reduces the size of the jar. That's always a bonus. >>> > > >>> > > I can commit this change as soon as I get the green light from the >>> > > other committers. I'd really like this to happen sooner than later >>> > > unless there is a good reason not to. The Xerces2 distribution is >>> > > distributed along with all kinds of packages such as Ant and Tomcat >>> > > (and many other apps) by default. And, actually, all we >>> > mostly need >>> > > is the endorsed packages which come with j2sdk1.4.x by default and >>> > > also come as separate jars otherwise. Using the ones that >>> > come with >>> > > Xerces2 just means that they are as up-to-date as possible since >>> > > Xerces2 is actively developed and stays on top of the >>> > latest changes. >>> > > >>> > > >>> > > As a side note, I also propose removing the source of >>> > gnu-regexp from >>> > > CVS and replacing it with the standard binary just like we store >>> > > bcel.jar in CVS. As far as I know, we haven't changed one thing in >>> > > that package and there isn't much reason to keep it in CVS. >>> > > >>> > > >>> > > Anyway, please let me know what you think of these proposals. >>> > > >>> > > later, >>> > > >>> > > Jake >>> > > >>> > > _______________________________________________ >>> > > XMLC mailing list >>> > > [email protected] >>> > > http://www.enhydra.org/mailman/listinfo.cgi/xmlc >>> > >>> > _______________________________________________ >>> > XMLC mailing list >>> > [email protected] >>> > http://www.enhydra.org/mailman/listinfo.cgi/xmlc >>> > >>> >>> >>>Confidentiality Warning: This e-mail contains information intended only >>>for the use of the individual or entity named above. If the reader of >>>this e-mail is not the intended recipient or the employee or agent >>>responsible for delivering it to the intended recipient, any >>>dissemination, publication or copying of this e-mail is strictly >>>prohibited. The sender does not accept any responsibility for any loss, >>>disruption or damage to your data or computer system that may occur >>>while using data contained in, or transmitted with, this e-mail. If >>>you have received this e-mail in error, please immediately notify us by >>>return e-mail. Thank you. >>> >>> >>>_______________________________________________ >>>XMLC mailing list >>>[email protected] >>>http://www.enhydra.org/mailman/listinfo.cgi/xmlc