Re: [PR] XBEAN-453 - honor Option.CASE_INSENSITIVE_PRO PERTIES for ctors [geronimo-xbean]

rmannibucau commented on code in PR #47:
URL: https://github.com/apache/geronimo-xbean/pull/47#discussion_r2653514553


##########
xbean-reflect/src/main/java/org/apache/xbean/recipe/ObjectRecipe.java:
##########
@@ -577,18 +577,33 @@ private Factory findFactory(Type expectedType) {
         return constructor;
     }
 
-    private Object[] extractConstructorArgs(Map propertyValues, Factory factory) {
+    private Object[] extractConstructorArgs(Map<Property, Object> propertyValues, Factory factory) {
         List<String> parameterNames = factory.getParameterNames();
         List<Type> parameterTypes = factory.getParameterTypes();
 
         Object[] parameters = new Object[parameterNames.size()];
         for (int i = 0; i < parameterNames.size(); i++) {
-            Property name = new Property(parameterNames.get(i));
             Type type = parameterTypes.get(i);
+            String name = parameterNames.get(i);
+
+            Property property = null;
+            if (options.contains(Option.CASE_INSENSITIVE_PROPERTIES)) {

Review Comment:
   what about testing if the map is case insensitive and if not just copy it in a treemap or alike (or do it in the caller)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe-nmThH5wfGryY1pf4d8vP8EB+6BGkLq7r@public.gmane.org

For queries about this service, please contact Infrastructure at:
users-pF6z+fRhj9EyzMRdD/[email protected]