Re: [PR] XBEAN-453 - honor Option.CASE_INSENSITIVE_PRO PERTIES for ctors [geronimo-xbean]

jungm commented on code in PR #47:
URL: https://github.com/apache/geronimo-xbean/pull/47#discussion_r2653704796


##########
xbean-reflect/src/main/java/org/apache/xbean/recipe/ReflectionUtil.java:
##########
@@ -1039,7 +1065,7 @@ private static String toParameterList(List<? extends Class<?>> parameterTypes) {
             for (int i = 0; i < parameterTypes.size(); i++) {
                 Class type = parameterTypes.get(i);
                 if (i > 0) buffer.append(", ");
-                buffer.append(type.getName());
+                buffer.append(type != null ? type.getName() : "...");

Review Comment:
   tomee passes `parameterTypes=null` which is then converted to a list of nulls in `findConstructor`, and `toParameterList` gets invoked to generate exception messages
   
   for example: https://ci-builds.apache.org/job/Tomee/view/tomee-10.x/job/tomee-10-build-full/org.apache.tomee$arquillian-tomee-webprofile-tests/43/testReport/junit/org.apache.openejb.arquillian.tests.bmp.local/BmpLocalEntityTest/___/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe-nmThH5wfGryY1pf4d8vP8EB+6BGkLq7r@public.gmane.org

For queries about this service, please contact Infrastructure at:
users-pF6z+fRhj9EyzMRdD/[email protected]