Re: [PR] XBEAN-453 - honor Option.CASE_INSENSITIVE_PRO PERTIES for ctors [geronimo-xbean]

rzo1 commented on code in PR #47:
URL: https://github.com/apache/geronimo-xbean/pull/47#discussion_r2655288185


##########
xbean-reflect/src/main/java/org/apache/xbean/recipe/ReflectionUtil.java:
##########
@@ -1039,7 +1065,7 @@ private static String toParameterList(List<? extends Class<?>> parameterTypes) {
             for (int i = 0; i < parameterTypes.size(); i++) {
                 Class type = parameterTypes.get(i);
                 if (i > 0) buffer.append(", ");
-                buffer.append(type.getName());
+                buffer.append(type != null ? type.getName() : "...");

Review Comment:
   I don't think it's a regression technically. More or less a bug of this utility method to produce a user facing error messages and don't account for null values. 
   
   What we might want to fix is likely another type of error message accounting for the null containing type list in case we fail via implicit ctor arg resolution and no types are available/present. That would be more helpful for the error msg.
   
   We can change and track it in an other issue and revert it here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe-nmThH5wfGryY1pf4d8vP8EB+6BGkLq7r@public.gmane.org

For queries about this service, please contact Infrastructure at:
users-pF6z+fRhj9EyzMRdD/[email protected]