Re: [PR] XBEAN-453 - honor Option.CASE_INSENSITIVE_PRO PERTIES for ctors [geronimo-xbean]

rmannibucau (via GitHub) <[email protected]>
Newsgroups gmane.comp.java.geronimo.devel
Message-ID <PR_kwDOAAOrUs669nAv-f4c830e8-013f-4562-b09c-fd23bc9ce37d@gitbox.apache.org>
rmannibucau commented on code in PR #47:
URL: https://github.com/apache/geronimo-xbean/pull/47#discussion_r2655433773


##########
xbean-reflect/src/main/java/org/apache/xbean/recipe/ReflectionUtil.java:
##########
@@ -1039,7 +1065,7 @@ private static String toParameterList(List<? extends Class<?>> parameterTypes) {
             for (int i = 0; i < parameterTypes.size(); i++) {
                 Class type = parameterTypes.get(i);
                 if (i > 0) buffer.append(", ");
-                buffer.append(type.getName());
+                buffer.append(type != null ? type.getName() : "...");

Review Comment:
   Proposed to use Object instead of ... to explicit it was a loose matching -> https://github.com/apache/geronimo-xbean/pull/48, feel free to take it back or rework it, it is just a proposal



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe-nmThH5wfGryY1pf4d8vP8EB+6BGkLq7r@public.gmane.org

For queries about this service, please contact Infrastructure at:
users-pF6z+fRhj9EyzMRdD/[email protected]
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.