Re: [PR] XBEAN-453 - honor Option.CASE_INSENSITIVE_PRO PERTIES for ctors [geronimo-xbean]
rzo1 (via GitHub) <[email protected]>
| Newsgroups | gmane.comp.java.geronimo.devel |
|---|---|
| Message-ID | <PR_kwDOAAOrUs669nAv-66dbebfa-6a2c-41cb-b49f-b0a7531e0ad1@gitbox.apache.org> |
rzo1 commented on code in PR #47:
URL: https://github.com/apache/geronimo-xbean/pull/47#discussion_r2659077643
##########
xbean-reflect/src/main/java/org/apache/xbean/recipe/ObjectRecipe.java:
##########
@@ -567,11 +574,18 @@ private Factory findFactory(Type expectedType) {
consturctorClass = type;
}
+ Set<String> availableProperties = getProperties().keySet();
Review Comment:
@jungm Can we move that block up, so `availableProperties` is also passed (in case insensitive order) into `findStaticFactory(...)` ? This is in light of https://github.com/apache/geronimo-xbean/pull/48 since same logic should apply for that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe-nmThH5wfGryY1pf4d8vP8EB+6BGkLq7r@public.gmane.org
For queries about this service, please contact Infrastructure at:
users-pF6z+fRhj9EyzMRdD/[email protected]