Re: [PR] [XBEAN-453] try to explicit the parameter types matched instead of us… [geronimo-xbean]

rzo1 commented on PR #48:
URL: https://github.com/apache/geronimo-xbean/pull/48#issuecomment-3707851493

   > side note: tomee can need to do its homeworks and fix all factories/constructors used in its service-jar.xml (for user ones we keep current behavior and just document it better?).
   
   Yes, I’ve already started fixing constructor argument names and adding explicit parameter types where necessary or possible. I’ve deployed a snapshot of this xbean branch and am running a full build to see whether this exposes any additional regressions in TomEE.
   
   From a documentation perspective, I agree that we should be clearer that users are strongly encouraged to supply parameter types to avoid implicit matching when it’s not required. For that reason, I think we should at least update the JavaDoc to explicitly list the supported options and clearly explain implicit versus explicit selection (also for the other methods / cases in this cass). I can follow up with a separate PR for the Javadoc changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe-nmThH5wfGryY1pf4d8vP8EB+6BGkLq7r@public.gmane.org

For queries about this service, please contact Infrastructure at:
users-pF6z+fRhj9EyzMRdD/[email protected]