Re: [PR] Fb perf [geronimo-xbean]

struberg commented on code in PR #57:
URL: https://github.com/apache/geronimo-xbean/pull/57#discussion_r3531346352


##########
xbean-finder/src/main/java/org/apache/xbean/finder/ClassFinder.java:
##########
@@ -200,28 +195,20 @@ private List<String> jar(URL location) throws IOException {
         InputStream in = url.openStream();
         try {
             JarInputStream jarStream = new JarInputStream(in);
-            return jar(jarStream);
+            jar(jarStream);
         } finally {
             in.close();
         }
     }
 
-    private List<String> jar(JarInputStream jarStream) throws IOException {
-        List<String> classNames = new ArrayList<String>();
-
+    private void jar(JarInputStream jarStream) throws IOException {
         JarEntry entry;
         while ((entry = jarStream.getNextJarEntry()) != null) {
             if (entry.isDirectory() || !entry.getName().endsWith(".class")) {
                 continue;
             }
-            String className = entry.getName();
-            className = className.replaceFirst(".class$", "");
-            if (className.contains(".")) continue;
-            className = className.replace('/', '.');
-            classNames.add(className);
+            readClassDef(jarStream);

Review Comment:
   Thanks for pointing it out anyway, I actually didn't have subtle behaviour changes regarding the Exceptions on the radar - txs!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe-nmThH5wfGryY1pf4d8vP8EB+6BGkLq7r@public.gmane.org

For queries about this service, please contact Infrastructure at:
users-pF6z+fRhj9EyzMRdD/[email protected]