Re: multipart/form-data support
Philip Aston <[email protected]>
| Newsgroups | gmane.comp.java.grinder.devel |
|---|---|
| Message-ID | <[email protected]> |
On 24/12/09 01:51, Hitoshi Amano wrote: > I've posted a patch: > http://sourceforge.net/tracker/?func=detail&aid=2914703&group_id=18598&atid=368598 > > I and my employer agree that the patch may be distributed under the > terms of The Grinder license. > Please, apply it. > > # Thanks for the great product! > -- > Amachang > e-mail: [email protected] > Thanks Amachang. This is now checked in and will be released in 3.4. I made a few tweaks to the patch - see http://grinder.svn.sourceforge.net/viewvc/grinder?view=rev&revision=4208 <http://grinder.svn.sourceforge.net/viewvc/grinder?view=rev&revision=4208>. The most significant of these was to merge the user supplied headers with the Content-Type header. I'm not sure your patch copes fully with the multipart data that contains files. You might consider extending the support as follows. * The working directory is hard coded to "/tmp" in ConnectionHandlerImplementation - this isn't general enough, and also will mean the user is likely to ignore or delete the recorded files. * Perhaps you could use the current working directory together with a FilenameManger to add a unique prefix to the files? * You would need to demangle the filenames on replay. * You could add comments to the generated script indicating that it relies on the files. I'll add these notes to the FR. Thanks and regards, - Phil ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Grinder-development mailing list Grinder-development-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/grinder-development