possible bug in HttpRecordingImplementation.java line 538?

James Liang <[email protected]> Tue, 15 Nov 2011 05:16:18 -0500
Newsgroups gmane.comp.java.grinder.devel
Message-ID <66360B3D135282408759C4D50104FB32693342E56A@mercury.utopiasystems.net>
if (!request.getUri().getExtends().equals(lastBaseURI) ||
                request.isSetBody() ||
==>        !(m_resourcePathPattern.matcher(request.getUri().getUnparsed()).matches() ||
                 lastResponseWasRedirect) ||
                currentPage == null) {
  currentPage = httpRecording.addNewPage();
}


Notice the ! () around both the resource path test and redirect test:
!(m_resourcePathPattern.matcher(request.getUri().getUnparsed()).matches() || lastResponseWasRedirect)

Perhaps this should look like this?

if (!request.getUri().getExtends().equals(lastBaseURI) ||
                request.isSetBody() ||
                !m_resourcePathPattern.matcher(request.getUri().getUnparsed()).matches() ||
                lastResponseWasRedirect ||
                currentPage == null) {
  currentPage = httpRecording.addNewPage();
}


James

------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1

_______________________________________________
Grinder-development mailing list
Grinder-development-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/grinder-development