Re: problems generating Clojure scripts

Spot on. Applied for next release.

- Phil

On 24/03/12 22:11, Bill Smith wrote:
> Attached is a patch for three problems with how the TCP proxy
> generates Clojure scripts.  (I am trying to follow the process
> outlined
> at http://grinder.sourceforge.net/development/contributing.html#How+to+give+back.
>  This is my first time to use Git and to submit patches here.  I am
> comfortable with the fix, but I apologize in advance if I am not
> submitting the patch correctly.)
>
> My employer (Tango Health) and I are happy for this work to be
> distributed under the terms of The Grinder license
> <http://grinder.sourceforge.net/license.html>.
>
> On Fri, Mar 23, 2012 at 1:10 PM, Bill Smith <[email protected]
> <mailto:[email protected]>> wrote:
>
>     I found a couple of problems with how the TCP proxy generates
>     Clojure scripts.  First, it uses the wrong syntax for method
>     calls.  For example, it does this:
>
>        (. valueFromHiddenInput httpUtilities "an Xpath")
>
>     when it should do this:
>
>        (.valueFromHiddenInput httpUtilities "an Xpath")
>
>     Second, it neglects to end a comment with a linefeed.  For
>     example, it does this:
>
>        (set-token :token_cx (.valueFromHiddenInput httpUtilities
>     "//g:token[@token-id=$token-id]/g:name")
>     ;"012652707207066138651:zudjtuwe28q")
>
>     when it should do this:
>
>        (set-token :token_cx (.valueFromHiddenInput httpUtilities
>     "//g:token[@token-id=$token-id]/g:name"))
>     ;"012652707207066138651:zudjtuwe28q"
>
>     or alternatively this:
>
>        (set-token :token_cx (.valueFromHiddenInput httpUtilities
>     "//g:token[@token-id=$token-id]/g:name")
>     ;"012652707207066138651:zudjtuwe28q"
>         )
>
>     Shall I submit a fix? 
>
>

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure

_______________________________________________
Grinder-development mailing list
Grinder-development-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/grinder-development