r9931 - apps/gobi/trunk/code/Page

[email protected] Fri, 18 Sep 2009 23:42:23 +0200 (CEST)
Newsgroups gmane.comp.java.helma.cvs
Message-ID <20090918214223.32CF03D0E3@mia>
Author: hannes
Date: 2009-09-18 23:42:23 +0200 (Fri, 18 Sep 2009)
New Revision: 9931

Modified:
   apps/gobi/trunk/code/Page/PageCore.js
Log:
Avoid null pointer in readEditForm

Details at http://dev.helma.org/trac/helma/changeset/9931

Modified: apps/gobi/trunk/code/Page/PageCore.js
===================================================================
--- apps/gobi/trunk/code/Page/PageCore.js	2009-09-18 21:33:03 UTC (rev 9930)
+++ apps/gobi/trunk/code/Page/PageCore.js	2009-09-18 21:42:23 UTC (rev 9931)
@@ -987,10 +987,8 @@
         var params = req.params.formdata;
         for each (var field in formDef) {
             var propName = field.name;
-            if (params[propName] == null) {
-                continue;
-            }
-            if (params && this.checkPermission(field.permission)) {
+            if (params && params[propName] != null
+                       && this.checkPermission(field.permission)) {
                 if (field.editor == LINK && params[propName]) {
                     if (persist) {
                         // evaluate links
@@ -1047,7 +1045,7 @@
                     // save generic property
                     data[propName] = params[propName];
                 }
-            } else if (data[propName] == null && field.defaultvalue != null) {
+            } else if (data[propName] === undefined && field.defaultvalue != null) {
                 // no permission to edit field, use default value if one is defined
                 data[propName] = field.defaultvalue;
             }