Re: jetty upgrade broke UTF-8 URLs

I committed a fres Jetty 4.2.27 compile with the attached patch, and
non-ASCII chars over AJP13 is now working again.

hannes


2007/3/28, Hannes Wallnoefer <[email protected]>:
> I had a look at this. The diff between 4.2.25 and 4.2.26 consists of
> 90% formatting changes, but this change hit me as suspicious:
>
> http://jetty.cvs.sourceforge.net/jetty/Jetty/src/org/mortbay/http/ajp/AJP13Connection.java?r1=1.33&r2=1.34&pathrev=MAIN
>
> ( this is actually Jetty 5, the change was backported to Jetty 4 here,
> together with other changes:)
> http://jetty.cvs.sourceforge.net/jetty/Jetty/src/org/mortbay/http/ajp/AJP13Connection.java?r1=1.21.2.3&r2=1.21.2.4&pathrev=Jetty_4_2
>
> That's just to keep you updated. I'm still investigating on what our
> options are (other than simply downgrading).
>
> hannes
>
> 2007/3/27, Michael Platzer <[email protected]>:
> > Hannes Wallnoefer schrieb:
> > > Hi Michi,
> > >
> > > downgrading is ok with me. Let's see how far we need to downgrade in
> > > order to fix this. Any idea?
> > >
> > Version 4.2.25 seems to be the last version, that still handles UTF-8
> > URLs the same way as 4.2.22.
> >
> >   michi
> >
> > _______________________________________________
> > Helma-user mailing list
> > [email protected]
> > http://helma.org/mailman/listinfo/helma-user
> >
>

_______________________________________________
Helma-user mailing list
[email protected]
http://helma.org/mailman/listinfo/helma-user

diff -Nur jetty-4.2.27/src/org/mortbay/http/ajp/AJP13Connection.java jetty-4.2.27-patched/src/org/mortbay/http/ajp/AJP13Connection.java
--- jetty-4.2.27/src/org/mortbay/http/ajp/AJP13Connection.java	2006-11-23 11:44:50.000000000 +0100
+++ jetty-4.2.27-patched/src/org/mortbay/http/ajp/AJP13Connection.java	2007-03-28 13:34:52.000000000 +0200
@@ -194,12 +194,9 @@
                         Code.warning(packet.toString());
                     }
                         
-                    String path=packet.getString();
-                    int sc=path.lastIndexOf(";");
-                    if (sc<0)
-                        request.setPath(URI.encodePath(path));
-                    else
-                        request.setPath(URI.encodePath(path.substring(0,sc))+path.substring(sc));
+                    // fix request path encoding issue, see 
+                    // http://grazia.helma.at/pipermail/helma-user/2007-March/006911.html
+                    request.setPath(packet.getString());
 
                     _remoteAddr=packet.getString();
                     _remoteHost=packet.getString();