[HtmlUnit] [HtmlUnit/htmlunit-rhino-fork] f19252: Fix #448: Correctly wrap the result of Math.imul a...

rbri <[email protected]> Sat, 21 Jul 2018 02:21:43 -0700
Newsgroups	gmane.comp.java.htmlunit.devel
Message-ID	<5b52fb27d7176_330d2ab4fa5eef78321ba@hookshot-fe-88eb02d.cp1-iad.github.net.mail>
  Branch: refs/heads/master
  Home:   https://github.com/HtmlUnit/htmlunit-rhino-fork
  Commit: f192525fa96ad2c1211ec984e300e475bf7e4bb6
      https://github.com/HtmlUnit/htmlunit-rhino-fork/commit/f192525fa96ad2c1211ec984e300e475bf7e4bb6
  Author: Sébastien Doeraene <[email protected]>
  Date:   2018-06-29 (Fri, 29 Jun 2018)

  Changed paths:
    M src/org/mozilla/javascript/NativeMath.java
    M testsrc/test262.properties

  Log Message:
  -----------
  Fix #448: Correctly wrap the result of Math.imul as an Int32.

As an added bonus, return an `int` from `js_imul` to avoid boxing.
At call site, it is assigned to a `double`, not an `Object`, so
eagerly boxing the result inside `js_imul` is counter-productive.


  Commit: 66da45a02fa7a53dbb7f4f312b2228919044ea58
      https://github.com/HtmlUnit/htmlunit-rhino-fork/commit/66da45a02fa7a53dbb7f4f312b2228919044ea58
  Author: Sébastien Doeraene <[email protected]>
  Date:   2018-07-02 (Mon, 02 Jul 2018)

  Changed paths:
    M src/org/mozilla/javascript/typedarrays/Conversions.java
    M testsrc/test262.properties

  Log Message:
  -----------
  Fix the conversions in typedarrays.Conversions.

Their implementation did not account for

a) the wrapping of number values larger than Integer.MAX_VALUE
   or lower than Integer.MIN_VALUE.
b) the behavior of `%` for negative values.

The complex problem of a) is already dealt with by
`ScriptRuntime.toInt32`, which we now leverage. Instead of `%` to
implement the `modulo` operation from the ECMAScript specification
(which is incorrect), we use sign-extending conversions such as
`(int)(byte)x` and bitwise ands such as `& 0xff`.

This fixes the test262 test in
`built-ins/TypedArrays/internals/Set/conversion-operation.js`.


  Commit: 741ef520c83e933361b174f9c6a41f0c3f187299
      https://github.com/HtmlUnit/htmlunit-rhino-fork/commit/741ef520c83e933361b174f9c6a41f0c3f187299
  Author: rbri <[email protected]>
  Date:   2018-07-02 (Mon, 02 Jul 2018)

  Changed paths:
    M testsrc/test262.properties

  Log Message:
  -----------
  we have many more 262 tests passing already - i think we have to use as many tests as possible to check our quality

before: 45858
after:  49719


  Commit: c5af11cb890909a7f95f2219ca2d5334b4bd41c5
      https://github.com/HtmlUnit/htmlunit-rhino-fork/commit/c5af11cb890909a7f95f2219ca2d5334b4bd41c5
  Author: rbri <[email protected]>
  Date:   2018-07-02 (Mon, 02 Jul 2018)

  Changed paths:
    M testsrc/test262.properties

  Log Message:
  -----------
  and some more; now we are at 51093


  Commit: 45be25338705a7a7e071f45ea56f420662d642a0
      https://github.com/HtmlUnit/htmlunit-rhino-fork/commit/45be25338705a7a7e071f45ea56f420662d642a0
  Author: rbri <[email protected]>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M testsrc/test262.properties

  Log Message:
  -----------
  Use as many test262 tests as possible to check our quality

before: 45858
after:  51093


  Commit: 2d89acb883576c0acc62ab4300da6c0029dc565d
      https://github.com/HtmlUnit/htmlunit-rhino-fork/commit/2d89acb883576c0acc62ab4300da6c0029dc565d
  Author: rbri <[email protected]>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M src/org/mozilla/javascript/NativeMath.java
    M testsrc/test262.properties

  Log Message:
  -----------
  implement missing Math functions


  Commit: 276c383c12b0c11dc94b9b0be17f693b36e4c8be
      https://github.com/HtmlUnit/htmlunit-rhino-fork/commit/276c383c12b0c11dc94b9b0be17f693b36e4c8be
  Author: rbri <[email protected]>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M testsrc/test262.properties

  Log Message:
  -----------
  disable some slow tests


  Commit: 47a2c3ac047502b12744e495b1cdf2d6bc0392b8
      https://github.com/HtmlUnit/htmlunit-rhino-fork/commit/47a2c3ac047502b12744e495b1cdf2d6bc0392b8
  Author: rbri <[email protected]>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M src/org/mozilla/javascript/typedarrays/NativeTypedArrayView.java
    A testsrc/jstests/harmony/typed-array-ctor.js
    A testsrc/org/mozilla/javascript/tests/harmony/TypedArrayCtorTest.java

  Log Message:
  -----------
  Support for `arguments` object as TypedArray constructor argument
this is the same as #297 but includes a simple test.


  Commit: c16327b89baa8f051da1a21f506d3cfcf876577a
      https://github.com/HtmlUnit/htmlunit-rhino-fork/commit/c16327b89baa8f051da1a21f506d3cfcf876577a
  Author: Attila Szegedi <[email protected]>
  Date:   2018-07-12 (Thu, 12 Jul 2018)

  Changed paths:
    M src/org/mozilla/javascript/NativeContinuation.java

  Log Message:
  -----------
  API for comparing continuation implementations


  Commit: 9bdfed1947781a3e68a0a4613c86dbceaca05798
      https://github.com/HtmlUnit/htmlunit-rhino-fork/commit/9bdfed1947781a3e68a0a4613c86dbceaca05798
  Author: Attila Szegedi <[email protected]>
  Date:   2018-07-12 (Thu, 12 Jul 2018)

  Changed paths:
    M src/org/mozilla/javascript/ArrowFunction.java
    M src/org/mozilla/javascript/BoundFunction.java
    A src/org/mozilla/javascript/EqualObjectGraphs.java
    M src/org/mozilla/javascript/IdFunctionObject.java
    A testsrc/org/mozilla/javascript/EqualObjectGraphsTest.java

  Log Message:
  -----------
  Algorithm for structural equality comparison of object graphs


  Commit: 3c9f9537e4dd1374c1dc7209e9b926ac2cf035ad
      https://github.com/HtmlUnit/htmlunit-rhino-fork/commit/3c9f9537e4dd1374c1dc7209e9b926ac2cf035ad
  Author: Attila Szegedi <[email protected]>
  Date:   2018-07-12 (Thu, 12 Jul 2018)

  Changed paths:
    M src/org/mozilla/javascript/Interpreter.java
    M src/org/mozilla/javascript/InterpreterData.java
    A testsrc/org/mozilla/javascript/tests/ContinuationComparisonTest.java
    A testsrc/org/mozilla/javascript/tests/ContinuationComparisonTest.js

  Log Message:
  -----------
  Use structural equality as the equality algorithm for Interpreter.CallFrame, which serves as the NativeContinuation implementation.


  Commit: d6dc98e5cfd25038d94d7642bc998abc478e6adb
      https://github.com/HtmlUnit/htmlunit-rhino-fork/commit/d6dc98e5cfd25038d94d7642bc998abc478e6adb
  Author: Attila Szegedi <[email protected]>
  Date:   2018-07-12 (Thu, 12 Jul 2018)

  Changed paths:
    M src/org/mozilla/javascript/EqualObjectGraphs.java

  Log Message:
  -----------
  Add workarounds for #437 and #449


  Commit: 211c5e64669799cbfc14afcde9fc5dde237e5d7a
      https://github.com/HtmlUnit/htmlunit-rhino-fork/commit/211c5e64669799cbfc14afcde9fc5dde237e5d7a
  Author: rbri <[email protected]>
  Date:   2018-07-21 (Sat, 21 Jul 2018)

  Changed paths:
    M src/org/mozilla/javascript/ArrowFunction.java
    M src/org/mozilla/javascript/BoundFunction.java
    A src/org/mozilla/javascript/EqualObjectGraphs.java
    M src/org/mozilla/javascript/IdFunctionObject.java
    M src/org/mozilla/javascript/Interpreter.java
    M src/org/mozilla/javascript/InterpreterData.java
    M src/org/mozilla/javascript/NativeContinuation.java
    M src/org/mozilla/javascript/NativeMath.java
    M src/org/mozilla/javascript/typedarrays/Conversions.java
    M src/org/mozilla/javascript/typedarrays/NativeTypedArrayView.java
    A testsrc/jstests/harmony/typed-array-ctor.js
    A testsrc/org/mozilla/javascript/EqualObjectGraphsTest.java
    A testsrc/org/mozilla/javascript/tests/ContinuationComparisonTest.java
    A testsrc/org/mozilla/javascript/tests/ContinuationComparisonTest.js
    A testsrc/org/mozilla/javascript/tests/harmony/TypedArrayCtorTest.java
    M testsrc/test262.properties

  Log Message:
  -----------
  Merge remote-tracking branch 'upstream/master'

# Conflicts:
#	src/org/mozilla/javascript/InterpreterData.java


Compare: https://github.com/HtmlUnit/htmlunit-rhino-fork/compare/a03ef44c7097...211c5e646697
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
HtmlUnit-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/htmlunit-develop