Re: [jgroups-dev] JGRP-1231 create a Discovery protocol using a javax.sql.DataSource

On 1/17/11 9:20 PM, Sanne Grinovero wrote:
> Hello,
> thank you for all the pointers; I've followed almost all, just the
> helper class for handling different databases is missing as it seems I
> could keep the SQL related code simple enough for the task.
>
> Here is a preview of the work so far:
> https://github.com/Sanne/JGroups/commit/62bdc79b9f549bc988f10838836f5acff2124ab6


Thanks for the work so far; I'll take a closer look when you've issued a 
pull request.

One quick comment re the design: you mentioned that PingData discards 
the view data. Is this correct ? We need the view data for MERGE2, which 
periodically kicks off a discovery to see if a merge is needed, and 
there it only requires views to be returned


> I'm still missing:
> 1) writing documentation - I'll have to wait for some help as
> JGRP-1273 is making me a blind writer


OK. Is Vladimir working on that ? Did they move the docbook templates 
from SVN to Git ?


> 2) to test the JNDI code - never run that yet.
>
> So this should be ready tomorrow, if you won't be too hard on the
> feedback on above patch :)


Excellent !


> I've had to change a constructor of PingData, it seemed to make sense
> and shouldn't break anything, but please double check it; there's no
> hard need to change it, it saves me two lines of code.

Sure, no problem


-- 
Bela Ban
Lead JGroups / Clustering Team
JBoss

------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Javagroups-development mailing list