[jgroups-dev] Question on PRIO Protocol Enhancement

Hey All-
I work for a company that uses JGroups extensively for all communication within our primary display application.  I am presently working on addressing an issue we are having with JGroups that others may have also encountered, and I was hoping to get some feedback from the group on how best to implement my changes so they may be re-used in the future.

The primary issue I am addressing is an Out-Of-Memory error. The primary source is the PRIO protocol (which a predecessor of mine initially developed)  along with the RATE-LIMITER protocol when a large number of messages are back-logged in the queue. My basic plan to address this issue is to add functionality to the PRIO protocol so that it will temporarily store the contents of pending messages to disk instead of storing them in memory, keeping a minimal amount of data in memory when large files are being sent over a slow pipe. I have a preliminary pass at these changes made and working against an older version of the JGroups PRIO protocol (JGroups-3.0.2), but would like to submit them back to the group for use by others.

This brought up my real question: What is the correct way to apply a change like the one above to the existing code base so it can be integrated back into JGroups? Should I modify the existing PRIO protocol to add this enhanced functionality, or create a new protocol (PRIO2?) which contains the existing PRIO protocol plus my enhancements?

I couldn't find any guidelines for such a change in the immediate documentation I found. From reviewing the existing code it appears that the new protocol approach (PRIO2?) is the more common approach, but I wanted to get feedback from those of you actively developing for JGroups to get your feel.

I look forward to your feedback. Thanks!
--

Steve West

------------------------------------------------------------------------------
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
_______________________________________________
Javagroups-development mailing list