Re: Maven-sar plugin changes

Hi,

From: "Mauro Talevi" <[email protected]>
> Yes, but once the plugin has been installed, it applies the postGoal
> to *all* java:compile, regardless of the fact that it is invoked in a
> project that has the sar plugin as a dependency.
> So it ends up being used in other projects that have no need for it.
> And I think this is counterintuitive - and could also be annoying.

Maybe but many other plugins have that identical behaviour and IIRC in the
future you will be required to explicitly define which plugins are run.

Even if it is run it has zero effect unless the user explicitly sets the
correct property.

> how about we try to keep it automatised but turn the thing on its head.
> ie have a dependency structure like:
>
>     <goal name="sar:metagenerate" prereqs="java:compile"/>
>     <goal name="sar:sar" prereqs="sar:metagenerate, jar:jar"/>
>
> in this way, someone wanting to compile and generate descriptors would
> call the sar:metagenerate goal in place of java:compile.

The problem is that people who want generate a jar still have to either have
a custom maven.xml or pass in two goals on cli

> Also, I've removed sar:init - all the variables required by plugin are
> set globally and the tasks are defined on demand in goals.

Can you make sure that this has not effected the engine component which uses
the metagenerate task but never attains the sar:metagenerate goal.