[jetty-dev] [jira] (JETTY-1504) HttpServletResponseWrapper ignored when using asyncContext?

Lukasz Lichota created JETTY-1504:
-------------------------------------

             Summary: HttpServletResponseWrapper ignored when using asyncContext?
                 Key: JETTY-1504
                 URL: https://jira.codehaus.org/browse/JETTY-1504
             Project: Jetty
          Issue Type: Bug
          Components: HTTP, Servlet
    Affects Versions: 8.1.2
            Reporter: Lukasz Lichota


Hello guys,
From my investigation it seems that HttpServletResponseWrapper is ignored when using async context. 
org.eclipse.jetty.server.AsyncContinuation only returns provided wrapped response is flag _responseWrapped is set:
    public ServletResponse getResponse()
    {
        if (_responseWrapped && _event!=null && _event.getSuppliedResponse()!=null)
            return _event.getSuppliedResponse();
        return _connection.getResponse();
    }

the flag can only be set to true in method:
public void suspend(ServletResponse response)
but this method is not called when creating async context. 

In class org.eclipse.jetty.server.Request in method
public AsyncContext startAsync(ServletRequest servletRequest, ServletResponse servletResponse)
the other version of suspend is called, which does not set the _responseWrapped flag, namely:
_async.suspend(_context,servletRequest,servletResponse);

is this is bug? Shouldn't the other suspend method (the one with 3 arguments) also check for wrapped servlet responses?


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email