[jetty-dev] [jira] (JETTY-1562) False positive 'Broken Null Check'
"Adriaan Peeters (JIRA)" <[email protected]> Thu, 11 Sep 2014 02:50:10 -0500 (CDT)
| Newsgroups | gmane.comp.java.jetty.general |
|---|---|
| Message-ID | <JIRA.156431.1410421679497.64133.1410421810191@codehaus01.managed.contegix.com> |
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org=
/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns=3D"http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Du=
tf-8" />
<meta name=3D"viewport" content=3D"width=3Ddevice-width, initial-sc=
ale=3D1.0, maximum-scale=3D1.0" /> <base href=3D"https://jira.codehaus.org"=
/>
<title>Message Title</title>
</head>
<body class=3D"jira" style=3D"color: #333; font-family: Arial, sans-ser=
if; font-size: 14px; line-height: 1.429">
<table id=3D"background-table" cellpadding=3D"0" cellspacing=3D"0" =
width=3D"100%" style=3D"border-collapse: collapse; mso-table-lspace: 0pt; m=
so-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse;=
mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id=3D"header-pattern-container" style=3D"padding: 0px; =
border-collapse: collapse; padding: 10px 20px">
<table id=3D"header-pattern" cellspacing=3D"0" cellpadd=
ing=3D"0" border=3D"0" style=3D"border-collapse: collapse; mso-table-lspace=
: 0pt; mso-table-rspace: 0pt">
<tr>
<td id=3D"header-avatar-image-container" valign=
=3D"top" style=3D"padding: 0px; border-collapse: collapse; vertical-align: =
top; width: 32px; padding-right: 8px"> <img id=3D"header-avatar-image" clas=
s=3D"image_fix" src=3D"https://jira.codehaus.org/secure/useravatar?avatarId=
=3D10232" height=3D"32" width=3D"32" border=3D"0" style=3D"border-radius: 3=
px; vertical-align: top" />
</td>
<td id=3D"header-text-container" valign=3D"midd=
le" style=3D"padding: 0px; border-collapse: collapse; vertical-align: middl=
e; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-=
line-height-rule: exactly; mso-text-raise: 1px"> <a class=3D"user-hover" re=
l=3D"apeeters" id=3D"email_apeeters" href=3D"https://jira.codehaus.org/secu=
re/ViewProfile.jspa?name=3Dapeeters" style=3D"color:#005500;; color: #3b73a=
f; text-decoration: none">Adriaan Peeters</a> <strong>updated</strong> an i=
ssue
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id=3D"email-content-container" style=3D"padding: 0px; b=
order-collapse: collapse; padding: 0 20px">
<table id=3D"email-content-table" cellspacing=3D"0" cel=
lpadding=3D"0" border=3D"0" width=3D"100%" style=3D"border-collapse: collap=
se; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border=
-collapse: separate">
<tr>
<!-- there needs to be content in the cell for =
it to render in some clients -->
<td class=3D"email-content-rounded-top mobile-e=
xpand" style=3D"padding: 0px; border-collapse: collapse; color: #fff; paddi=
ng: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px s=
olid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border=
-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; heig=
ht: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: =
exactly">
</td>
</tr>
<tr>
<td class=3D"email-content-main mobile-expand "=
style=3D"padding: 0px; border-collapse: collapse; border-left: 1px solid #=
ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding=
: 0 15px 0 16px; background-color: #fff">
<table class=3D"page-title-pattern" cellspa=
cing=3D"0" cellpadding=3D"0" border=3D"0" width=3D"100%" style=3D"border-co=
llapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class=3D"page-title-pattern-fir=
st-line " style=3D"padding: 0px; border-collapse: collapse; font-family: Ar=
ial, sans-serif; font-size: 14px; padding-top: 10px"> <a href=3D"https://ji=
ra.codehaus.org/browse/JETTY" style=3D"color: #3b73af; text-decoration: non=
e">Jetty</a> / <a href=3D"https://jira.codehaus.org/browse/JETTY-1562" styl=
e=3D"color: #3b73af; text-decoration: none"><img src=3D"https://jira.codeha=
us.org/images/icons/issuetypes/bug.png" height=3D"16" width=3D"16" border=
=3D"0" align=3D"absmiddle" alt=3D"Bug" style=3D"vertical-align: text-bottom=
" /></a> <a href=3D"https://jira.codehaus.org/browse/JETTY-1562" style=3D"c=
olor: #3b73af; text-decoration: none">JETTY-1562</a>
</td>
</tr>
<tr>
<td style=3D"vertical-align: top;; =
padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20p=
x; line-height: 30px; mso-line-height-rule: exactly" class=3D"page-title-pa=
ttern-header-container"> <span class=3D"page-title-pattern-header" style=3D=
"font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: =
30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: m=
iddle"> <a href=3D"https://jira.codehaus.org/browse/JETTY-1562" style=3D"co=
lor: #3b73af; text-decoration: none">False positive 'Broken Null Check'</a>=
</span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class=3D"email-content-main mobile-expand =
wrapper-special-margin" style=3D"padding: 0px; border-collapse: collapse; b=
order-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; bo=
rder-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; padding-top=
: 10px; padding-bottom: 5px">
<table class=3D"keyvalue-table" style=3D"bo=
rder-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<th style=3D"color: #707070; font: =
normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; =
padding: 2px 0">
Change By:
</th>
<td style=3D"padding: 0px; border-c=
ollapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0=
2px 5px; vertical-align: top"> <a class=3D"user-hover" rel=3D"apeeters" id=
=3D"email_apeeters" href=3D"https://jira.codehaus.org/secure/ViewProfile.js=
pa?name=3Dapeeters" style=3D"color:#005500;; color: #3b73af; text-decoratio=
n: none">Adriaan Peeters</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class=3D"email-content-main mobile-expand =
issue-description-container" style=3D"padding: 0px; border-collapse: collap=
se; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: =
0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; paddin=
g-top: 5px; padding-bottom: 10px">
<table class=3D"text-paragraph-pattern" cel=
lspacing=3D"0" cellpadding=3D"0" border=3D"0" width=3D"100%" style=3D"borde=
r-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-fa=
mily: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-heigh=
t-rule: exactly; mso-text-raise: 2px">
<tr>
<td class=3D"text-paragraph-pattern=
-container mobile-resize-text " style=3D"padding: 0px; border-collapse: col=
lapse; padding: 0 0 10px 0"> <span class=3D"diffcontext">The following=
code triggers the 'Broken Null Check' i=
ncorrectly.</span> <span class=3D"diffremovedchars" style=3D"background-col=
or: #ffe7e7; text-decoration:line-through;"> nummer</span> <span class=
=3D"diffaddedchars" style=3D"background-color:#ddfade;"><br /><br />{{numbe=
r}}</span> <span class=3D"diffcontext"> is a local vari=
able.</span> <span class=3D"diffaddedchars" style=3D"background-color:#ddfa=
de;"> {{</span> <span class=3D"diffcontext"> this.</span> <span c=
lass=3D"diffremovedchars" style=3D"background-color: #ffe7e7; text-decorati=
on:line-through;">nummer</span> <span class=3D"diffaddedchars" style=3D"bac=
kground-color:#ddfade;">number}}</span> <span class=3D"diffcontext"> i=
s an object variable that is always not-=
null.<br /><br />{code}<br />if (</span> <span class=3D"diffremovedcha=
rs" style=3D"background-color: #ffe7e7; text-decoration:line-through;">numm=
er</span> <span class=3D"diffaddedchars" style=3D"background-color:#ddfade;=
">number</span> <span class=3D"diffcontext"> =3D=3D null &am=
p;& this.</span> <span class=3D"diffremovedchars" style=3D"backgro=
und-color: #ffe7e7; text-decoration:line-through;">nummer</span> <span clas=
s=3D"diffaddedchars" style=3D"background-color:#ddfade;">number</span> <spa=
n class=3D"diffcontext">.isEmpty()) {<br />{code}<br /><br /></span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class=3D"email-content-main mobile-expand "=
style=3D"padding: 0px; border-collapse: collapse; border-left: 1px solid #=
ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding=
: 0 15px 0 16px; background-color: #fff">
<table id=3D"actions-pattern" cellspacing=
=3D"0" cellpadding=3D"0" border=3D"0" width=3D"100%" style=3D"border-collap=
se: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Ar=
ial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: =
exactly; mso-text-raise: 1px">
<tr>
<td id=3D"actions-pattern-container=
" valign=3D"middle" style=3D"padding: 0px; border-collapse: collapse; paddi=
ng: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align=3D"left" style=3D"=
border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class=3D"actions-pa=
ttern-action-icon-container" style=3D"padding: 0px; border-collapse: collap=
se; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso=
-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <=
a href=3D"https://jira.codehaus.org/browse/JETTY-1562#add-comment" target=
=3D"_blank" title=3D"{getText($action.text)}" style=3D"color: #3b73af; text=
-decoration: none"> <img class=3D"actions-pattern-action-icon-image" src=3D=
"https://jira.codehaus.org/images/mail/comment-icon.png" alt=3D"Add Comment=
" title=3D"{Add Comment}-icon" height=3D"16" width=3D"16" border=3D"0" styl=
e=3D"vertical-align: middle" /> </a>
</td>
<td class=3D"actions-pa=
ttern-action-text-container" style=3D"padding: 0px; border-collapse: collap=
se; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso=
-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a hre=
f=3D"https://jira.codehaus.org/browse/JETTY-1562#add-comment" target=3D"_bl=
ank" title=3D"Add Comment" style=3D"color: #3b73af; text-decoration: none">=
Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it t=
o render in some clients -->
<tr>
<td class=3D"email-content-rounded-bottom mobil=
e-expand" style=3D"padding: 0px; border-collapse: collapse; color: #fff; pa=
dding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff=
; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc=
; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bot=
tom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id=3D"footer-pattern" style=3D"padding: 0px; border-col=
lapse: collapse; padding: 12px 20px">
<table id=3D"footer-pattern-container" cellspacing=3D"0=
" cellpadding=3D"0" border=3D"0" style=3D"border-collapse: collapse; mso-ta=
ble-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id=3D"footer-pattern-text" class=3D"mobile-=
resize-text" width=3D"100%" style=3D"padding: 0px; border-collapse: collaps=
e; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, san=
s-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <s=
pan id=3D"footer-build-information">(v6.1.6#6162-<span title=3D"7af547ce7c8=
4dbb7c1e345a65437ed7b85efffa2" data-commit-id=3D"7af547ce7c84dbb7c1e345a654=
37ed7b85efffa2}">sha1:7af547c</span>)</span>
</td>
<td id=3D"footer-pattern-logo-desktop-container=
" valign=3D"top" style=3D"padding: 0px; border-collapse: collapse; padding-=
left: 20px; vertical-align: top">
<table style=3D"border-collapse: collapse; =
mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id=3D"footer-pattern-logo-deskt=
op-padding" style=3D"padding: 0px; border-collapse: collapse; padding-top: =
3px"> <img id=3D"footer-pattern-logo-desktop" src=3D"https://jira.codehaus.=
org/images/mail/footer-desktop-logo.png" alt=3D"Atlassian logo" title=3D"At=
lassian logo" width=3D"169" height=3D"36" class=3D"image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email