jicarilla-sandbox/platform/container/impl/src/java/org/jicarilla/container/builder DefaultBuilder.java,1.10,1.11

Leo Simons <[email protected]>
Newsgroups gmane.comp.java.jicarilla.cvs
Message-ID <[email protected]>
Update of /cvsroot/jicarilla/jicarilla-sandbox/platform/container/impl/src/java/org/jicarilla/container/builder
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15658/platform/container/impl/src/java/org/jicarilla/container/builder

Modified Files:
	DefaultBuilder.java 
Log Message:
100% coverage for DefaultBuilder...boy that was easy!

Index: DefaultBuilder.java
===================================================================
RCS file: /cvsroot/jicarilla/jicarilla-sandbox/platform/container/impl/src/java/org/jicarilla/container/builder/DefaultBuilder.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -d -r1.10 -r1.11
--- DefaultBuilder.java	17 Mar 2004 14:14:16 -0000	1.10
+++ DefaultBuilder.java	17 Mar 2004 16:35:26 -0000	1.11
@@ -201,8 +201,8 @@
         while( it.hasNext() )
         {
             final Object provider = it.next();
-            if( provider == null )
-                continue;
+            // checks against null in place... if( provider == null )
+            //    continue;
 
             doAdd( provider );
         }
@@ -212,8 +212,8 @@
     {
         final Object helper = m_helpers.getResolver().get( provider );
 
-        if( helper == null )
-            throw new NoUsableHelperException( provider );
+        // DefaultHelper will always work... if( helper == null )
+        //    throw new NoUsableHelperException( provider );
 
         if( helper instanceof ContainerAwareBuilderHelper )
         {
@@ -225,7 +225,7 @@
 
             m_container.registerAdapter( selector, adapter );
         }
-        else if( helper instanceof BuilderHelper )
+        else // we assume builder is correctly populated... if( helper instanceof BuilderHelper )
         {
             final BuilderHelper builder = (BuilderHelper)helper;
             final KeyAwareAdapter adapter = builder.getAdapter( provider );
@@ -233,13 +233,13 @@
 
             m_container.registerAdapter( selector, adapter );
         }
-        else
+        /*else
         {
             throw new JicarillaIllegalStateException(
                     "Found a helper for " + provider + " but the helper is " +
                     "not a ContainerAwareBuilderHelper or a BuilderHelper " +
                     "so we don't know what to do with it!" );
-        }
+        }*/
     }
 
     protected void addHelpers()



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.