Re: [rvm-research] Bug: Locks returned from thread cachedFreeLock are not marked active

Hi Carl

Sorry to take so long to get back to you. I need to read the diff in the context of the rest of the code. But let's talk tomorrow.

Richard

On 23 Apr 2013, at 18:15, Carl Ritson <[email protected]> wrote:

> Hi,
> 
> I noticed that in the code path for Lock.allocate() which returns a
> cached lock from RVMThread's cachedFreeLock the lock returned is not
> marked active.  The only impact of this as far as I can tell is that
> many locks will not be reported via dumpLocks(), for example when the
> VM fails.  This can hamper debugging, but that's all.
> 
> Attached is a one line diff to fix this bug.
> 
> Kind regards,
> 
> Carl
> <cached-log-active.diff>------------------------------------------------------------------------------
> Try New Relic Now & We'll Send You this Cool Shirt
> New Relic is the only SaaS-based application performance monitoring service 
> that delivers powerful full stack analytics. Optimize and monitor your
> browser, app, & servers with just a few lines of code. Try New Relic
> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr_______________________________________________
> Jikesrvm-researchers mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/jikesrvm-researchers


------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr