Re: [rvm-research] Bug in Classpath's VMProcess w.r.t. use of notify() instead of notifyAll()

Hi,

2013/4/26 Erik Brangs <[email protected]>:
> I'm a bit busy at the moment but I might be able to make time for
> applying this patch and your quick fix for the bootloader issue this
> weekend. Please fill out the appropriate statement(s) of origin from
> http://www.jikesrvm.org/Contributions for your contributions.

With respect to the bootloader issue I would still like to take the
opportunity to submit a alternative patch, I just haven't had the time
yet to write and test an alternative.  Hopefully I will do in the next
few days.

I've attached an alternate diff to the one previously posted which was
based on Classpath Git which has different whitespace usage than
Classpath 97p2.  The attached file should apply cleanly to Classpath
97p2.

---
        STATEMENT OF ORIGIN FOR A SINGLE CONTRIBUTOR

I, Carl Ritson:

(a) represent that either:

  (i) I am the only author and owner of the contributed software
      (described as/entitled Fix for use of notify() in Classpath's
VMProcess class),
      which was neither derived nor copied from any other software,
  or

 (ii) that any exception to (i) is software which was obtained under the
      EPL (Eclipse Public License),

and

(b)  hereby agree to license this contributed software under the EPL.
---

Kind regards,

Carl

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr

_______________________________________________
Jikesrvm-researchers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/jikesrvm-researchers

--- vm/reference/java/lang/VMProcess.java	2006-09-05 22:33:25.000000000 +0100
+++ vm/reference/java/lang/VMProcess.java	2013-04-25 20:59:20.318705390 +0100
@@ -152,7 +152,7 @@
 		    {
 		      process.exitValue = exitValue;
 		      process.state = TERMINATED;
-		      process.notify();
+		      process.notifyAll();
 		    }
 		}
 	      else
@@ -214,7 +214,7 @@
 	      process.state = TERMINATED;
 	      process.exception = t;
 	    }
-	  process.notify();
+	  process.notifyAll();
 	}
     }
   }
@@ -243,7 +243,7 @@
 	  }
 	else
 	  {
-	    workList.notify();
+	    workList.notifyAll();
 	  }
       }