Re: [rvm-research] Exception while executing Junit Test Cases while running pre-commit

Hi,

On 29.04.2013 02:56, Pushparaj Motamari wrote:
> [...] please suggest next course of action. I am working on fix for the
> bug RVM-1017.

I assume that you're basing your attempts to fix RVM-1017 (= Implicit
unlock in synchronized method relies on local variable 0) on an
unmodified Jikes RVM. Do you want to fix RVM-1017 for yourself or do you
plan to contribute a fix to mainline?

In the latter case, it might be a good idea to discuss what the right
approach to fix the issue is (e.g. in a new thread on rvm-core). In the
former case, you're of course free to choose any approach you like.

I'm not sure if it's a good idea to reserve an extra word for every
method. The reuse of the slot for the this pointer is only a problem
with respect to synchronized methods. Looking at your diff, I also don't
understand why you're excluding certain internal classes.

My suggestion is the following: choose an approach for fixing the bug,
implement it in the baseline compiler and test the fix extensively.
After you're done with the baseline compiler, you can start to fix the
bug in the opt compiler. Not sure if that's helpful to you. Please try
to ask a more specific question if it isn't.


Kind regards,

Erik Brangs

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr