Re: [rvm-research] Implementation of setPriority/getPriority for RVMThread (RVM-750)

Hi,

On 31.07.2013 10:52, Carl Ritson wrote:
> Hi,
> 
>> thanks for the patches. We appreciate your contributions.
>>
>> There was an implementation of RVM-750 in MRP (see
>> http://git.codehaus.org/gitweb.cgi?p=mrp.git;a=commitdiff;h=bee01390c061dfbe746f79bd45affdae94529b33).
>> Could you comment on the different approaches?
> 
> The approach in the linked patch is the same as my patch for systems
> where pthread static priority is possible; however, it will have no
> effect on Linux.  The linked implementation is incomplete as the
> priority of new threads will not be set when they are created, and
> getPriority will not return the OS priority of a thread if it has been
> set correctly or otherwise.  This is a point for discussion in many
> implementations setPriority always succeeds and the result of
> getPriority is always the value passed to the last setPriority,
> regardless of the OS priority of the thread.  My approach will always
> return the OS priority.

Thanks for your comments.

> It should be portable, although I don't have access to an AIX system to test.

I don't have AIX access either. AFAIK Dave is the only team member with
access to AIX machines. I'll probably just commit the patches and revert
them later if the regression tests show any problems.

> Ah, sorry about that.
> Would you like me to fix this and the above, and provide new patches?

Please do so. I don't have access to an OS X machine, so it would be
great if you could check that pre-commit test run passes on your OS X
machine.

Please consider asking the GNU Classpath project if they are interested
in your patch.


Kind regards,

Erik Brangs

------------------------------------------------------------------------------
Get your SQL database under version control now!
Version control is standard for application code, but databases havent 
caught up. So what steps can you take to put your SQL databases under 
version control? Why should you start doing it? Read more to find out.
http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk