Re: [rvm-research] Bytecode merge is disabled for aload in Baseline compiler

Hi,

On 21.11.2017 09:08, Lingyu Zhu wrote:
> Should I provide one contributor statement for each patch I send in the future or Is it one time thing? 

If you don't want to provide a contributor statement for each patch, you can use the "batch" contributor statement at http://www.jikesrvm.org/files/batch-single-contrib.txt .

> STATEMENT OF ORIGIN FOR A SINGLE CONTRIBUTOR
> [...]

Thanks.

I've reviewed the patch and it looks mostly correct.

If you want to be listed as the author in the commit message (i.e. author field in git log), please send a patch that can be applied with git am (e.g. using git format-patch -1 HEAD). In that case, you should also remove the unused import for JBC_nop from the BaselineCompiler and remove the commented out line. Unused imports cause Checkstyle failures which makes the pre-commit test run fail. If being mentioned in the commit message is enough for you, I would just fix the remaining issues myself.


Kind regards,

Erik Brangs

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot