Re: [rvm-research] [patch] Remove some outdated comments and Make emit_unresolved_getstatic more like emit_resolved_getstatic
Erik Brangs <[email protected]> Sun, 26 Nov 2017 19:07:23 +0100
| Newsgroups | gmane.comp.java.jikes.rvm.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi, the patch is incorrect. The method peekResolvedField() may return null which will make your code fail. There's lots of room for improvement in our test suite but the pre-commit test run would have caught this. If you're using Ant (rather than buildit), you can use "ant -f test.xml -Dtest-run.name=pre-commit" to run it. There's more information on tests in the user guide (which also needs improvements). Kind regards, Erik Brangs ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot