Re: [rvm-research] [PATCH] enlarge org.mmtk.utility.heap.layout.Mmapper()'s second

Hi,

On 15.12.2017 11:03, Lingyu Zhu wrote:
> In 64-bit VM, all spaces' extends are 2^41 pages, in which case it will lead to overflow.

I've looked at the code and it seems to me that spaces' extents are 2^41 bytes which means 2^29 pages, which fits into an int. Anyway, if you do want to change this, please use Extent instead of long. The number of pages ought to be unsigned because a negative number of pages doesn't make any sense. Also, a contributor statement is required for each patch if you're not using batch contributor statement.


Kind regards,

Erik Brangs

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot