Re: Small patches to previously posted updates from OFBiz

David E Jones wrote:
> Anthony and others,
> 
> Since sending out the last set of files there are two that I have made small 
> changes to.
> 
> The RepositoryContent is now a bit more intelligent about handling 
> lastModified times, and should be somewhat faster depending on how the 
> repository is implemented.

I am a bit reluctant to add these changes because they do not really fit into the purpose of the RepositoryContent class.  Your implementation assumes that a RepositoryContent object is "live" in that it can go back to the Repository and ask for updated content, whereas my current implementation considers the RepositoryContent to be a snapshot of the content at the time it is requested and that you should go back to the SiteContext.getContent() method to access a content object.  

Let me ask you this: is your new implementation necessary for your system so much so that it is worth changing the purpose of the RepositoryContent class?  Are you caching the RepositoryContent objects or doing something else which requires those objects to be "live"?

> The ScriptAction class now passes the "canonical" path as the source to BSF. 
> This provides a more unique identifier to make is easier to cache and, when 
> debugging, locate the script file you are working with.

I have added your changes for the ScriptAction class, however be aware that it will require some pretty hefty changes as I move towards supporting unexpanded WARs.  Eventually there will be an ActionContent class which is similar to the RepositoryContent class.

Sincerely,
Anthony Eden



-------------------------------------------------------
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger 
for complex code. Debugging C/C++ programs can leave you feeling lost and 
disoriented. TotalView can help you find your way. Available on major UNIX 
and Linux platforms. Try it free. www.etnus.com