Re: Default Template discussion
"Dirk Frederickx" <[email protected]>
| Newsgroups | gmane.comp.java.jspwiki.user |
|---|---|
| Message-ID | <[email protected]> |
Janne, Some feedback inline... > How about putting them under the "G'day" link? That's where the > person's name always is anyway. Indeed. that's exactly where they will come. One little box with G'day + Login + Prefs etc. > > - Add the Diff on the highest TAB level (Call it Version) > > I'm not sure whether that's a good idea, but at least calling it > something else than "Diff" is a good thing. "Version" or "History" > sounds a lot better. Janne, why not bring the "Diff" tab inside the "Info" tab. You made this suggestion some mails back, if i'm not mistaken. Unless of course, there is a good reason to have a separate Diff.jsp url ? This would imply merging Info.jsp and Diff.jsp. Based on the parameters on the URL, we can decide which info to display inside the Info tab. > > - Drop the page-actions at the bottom > > Or leave "Add comment". > > - the More... button should really become the last TAB, which > > becomes > > a dropdown menu when you hover your mouse over it, but becomes a > > really > > TAB-page when you click on it. > > Hm. Sounds strange. Besides, how does this work on browsers which > are not supporting all the Mootools functionality? Yeah yeah. some hacking would still be required to make it non-js browser compliant, as the current more dropdown is. (standard rendering is DROPDOWN SELECT list) I was just 'loud thinking' about an elegant way to make that more menu Admin configurable ;-) > > - Place the comment add button in the EDIT tab > > I don't think this is a good idea. Adding a comment is not > conceptually the same thing as changing the page content. The whole strategy on 'Add Comments' in JSPWiki is today rather weak, IMHO. It is actually just a page append function. Moreover, it's pretty confusing when you look how jspwiki weblog entries are handling comments. Weblog comments are really added to a separate comment page. You also get automatically info on how many comments have been written againts a certain weblog entry, etc. ( comment(4) ) Why not adopt such a more robust strategy to commenting in general. The comment tab would then be similar to the Attach tab. It would show how many comments have been written already, show you all comments inside that comment tab and allow you to add comments. With the current comment functionality of JSPWiki, this is not possible as you can not reconstruct which part of the page are actually comments, etc.