Re: DataPoint bug: record 2191102 on SourceForge tracker

Amanda,

I think it's best to require @DataPoint, but we've been vague in the past.
Some of the self-tests may need updating.

Were there unit test failures before you started?

Let's go ahead with two separate patches.

   David Saff

On Wed, Dec 17, 2008 at 11:07 AM, Amanda Robinson <[email protected]
> wrote:

> I'm taking a look at the bug pasted below, in which not only
> @DataPoint-annotated fields but all static fields in a
> @RunWith(Theories.class) class are used as potential arguments for
> @Theory methods.
>
> Is it correct that only fields with @DataPoint annotations should be
> used? When I tried implementing a fix, all of a sudden there were
> twice as many unit test failures overall. It looks like many of the
> unit tests do not use the @DataPoint annotation for all fields they
> expect to use in Theory methods.
>
> I've got a fix ready for bug 2196462, @Theory annotation optional when
> running with Theories. Can I submit one patch to fix both that and
> this bug, or is it best if I submit two separate patches?
>
> Thanks,
> ~Amanda
>
>
> ------------------------------------------------------------------------------
> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
> The future of the web can't happen without you.  Join us at MIX09 to help
> pave the way to the Next Web now. Learn more and register at
>
> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
> _______________________________________________
> Junit-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/junit-devel
>

------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/

_______________________________________________
Junit-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/junit-devel