should @Ignore processing and Filter processing be combined?

This topic started from
https://github.com/junit-team/junit/pull/635#issuecomment-14189604.

Full disclosure: I'm for combining such processing since my group uses
Filter notification to know which tests are being skipped in CI while
allowing such tests to be run on dev machines. Our goal is to
eliminate such tests, but exposure of those tests is required to
achieve this goal.

The following (especially the cons since I'm biased and there's lots
about JUnit I don't yet understand) will likely be missing items but
I'll try to be fair about them. If there's anything missing, I'm sure
people will jump in.

Pro's:
* Simpler code. @Ignore processing would simply be just another
filter. Existing duplicate code to check for @Ignore annotations will
disappear.
* Conceptually simpler. @Ignore and Filters aren't two separate things
with different hard-coded nuances.

Con's:
* Slower performance. Since notifications will have to be made, the
set of tests to be run can't be culled down. Such slower performance
is theoretical and ought to be measured.

Potential alternatives:
* Have an option (somewhere) that allows notification for filtered tests.
* Have a fireFiltered() method for notifiers. I think this would still
require changes to AllDefaultPossibilitiesBuilder.runnerForClass()
such that it returns something similar to IgnoredClassRunner for tests
that are filtered out.

Noel


------------------------------------

Yahoo! Groups Links

<*> To visit your group on the web, go to:
    http://groups.yahoo.com/group/junit/

<*> Your email settings:
    Individual Email | Traditional

<*> To change settings online go to:
    http://groups.yahoo.com/group/junit/join
    (Yahoo! ID required)

<*> To change settings via email:
    [email protected] 
    [email protected]

<*> To unsubscribe from this group, send an email to:
    [email protected]

<*> Your use of Yahoo! Groups is subject to:
    http://docs.yahoo.com/info/terms/