Re: Re: JUnit 4.12-beta-1 is released

On Mon, Aug 11, 2014 at 3:54 AM, [email protected] [junit] <
[email protected]> wrote:

>
>
> Hi,
>
> I've tried porting an in-house runner that previously has been using 4.8
> into 4.12-beta-1 and and I've found no issues that must be fixed. So to me
> it looks ready for release.
>
> One thing that was slightly annoying is that instead of removing
> org.junit.internal.AssumptionViolatedException, you've deprecated and
> duplicated it into org.junit.AssumptionViolatedException. This caused me
> some headache as we had code catching the former class type and suddenly it
> looked like assumptions had stopped working until I realized I had to
> change the import statement. For the future, I'd prefer that you just
> remove the original class as then we'll get a compiler error instead of
> runtime failures.
>

Thanks for the feedback, Chris

Could you give us an example of the code that was broken by our
introduction of an external AssumptionViolatedException? The new external
one is a subclass of the internal one, so the thinking was any code outside
of JUnit that tried to catch the internal AssumptionViolatedException would
still catch exceptions thrown by Assume. Was your code specifically
throwing the internal AssumptionViolatedException? I thought we handled
that as well.

I would be very interested in knowing more details.

-- Kevin