Re: Contribution idea: assertions that directly support Java 8's Optional

"Mark Silvis [email protected] [junit]" <[email protected]> Mon, 5 Oct 2015 01:17:08 -0400
Newsgroups gmane.comp.java.junit.user
Message-ID <[email protected]>
--Apple-Mail=_DC7312E4-F20E-477D-9E75-B9F9F4AD6C03
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

Stefan,

Thank you for the link. After a cursory glance, it seems like digging into =
Hamcrest to assert that an optional value is empty, for example, is more wo=
rk for the user than it=E2=80=99s worth. I would rather stick to David=E2=
=80=99s suggestion of assertEquals(x, Optional.empty()) for this case, unle=
ss the assertion was especially complex. Then, as I mentioned to David, tha=
t isn=E2=80=99t nearly as clean (in my opinion) as an assertEmpty would be.

Best,
Mark


> On Oct 5, 2015, at 12:18 AM, Stefan Bechtold [email protected] [juni=
t] <[email protected]> wrote:
>=20
>=20
> Hi Mark
>=20
> Actually, I think this sounds more as an addition to a matcher framework =
like hamcrest rather than an addition to JUnit itself. What do you think?=20
>=20
> see also: https://github.com/hamcrest/JavaHamcrest/issues/82 <https://git=
hub.com/hamcrest/JavaHamcrest/issues/82>
>=20
> all the best
>=20
> Stefan
>=20
>=20
> Am 04.10.2015 um 19:55 schrieb Mark Silvis [email protected] <mailto:m=
[email protected]> [junit] <[email protected] <mailto:junit@yahoogrou=
ps.com>>:
>=20
>>=20=20
>> I would like to contribute to JUnit, and I think I have a good idea for =
a feature. I=E2=80=99ve found that it would be nice to have assertions that=
 explicitly supported Java 8=E2=80=99s Optional class. I=E2=80=99m thinking=
 something along the lines of assertEmpty() and assertPresent(). Would such=
 an addition be welcomed?
>>=20
>> Thanks,
>> Mark
>>=20
>=20
>=20


--Apple-Mail=_DC7312E4-F20E-477D-9E75-B9F9F4AD6C03
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable





<head>

<style type=3D"text/css">
<!--

/* start of attachment style */
       .ygrp-photo-title{
         clear: both;
         font-size: smaller;
         height: 15px;
         overflow: hidden;
         text-align: center;
         width: 75px;
       }
       div.ygrp-photo{
         background-position: center;
         background-repeat: no-repeat;
         background-color: white;
         border: 1px solid black;
         height: 62px;
         width: 62px;
       }

       div.photo-title=20
         a,
         div.photo-title a:active,
         div.photo-title a:hover,
         div.photo-title a:visited {
           text-decoration: none;=20
       }

       div.attach-table div.attach-row {
         clear: both;
       }

       div.attach-table div.attach-row div {
         float: left;
         /* margin: 2px;*/
       }

       p {
         clear: both;
         padding: 15px 0 3px 0;
	 overflow: hidden;
       }

       div.ygrp-file {
         width: 30px;
         valign: middle;
       }
       div.attach-table div.attach-row div div a {
         text-decoration: none;
       }

       div.attach-table div.attach-row div div span {
         font-weight: normal;
       }

       div.ygrp-file-title {
         font-weight: bold;
       }
 /* end of attachment style */
        -->
        </style>
        </head>
<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html charset=
=3Dutf-8"></head><body style=3D"word-wrap: break-word; -webkit-nbsp-mode: s=
pace; -webkit-line-break: after-white-space;" class=3D"">


<!-- |**|begin egp html banner|**| -->

<br><br>

<!-- |**|end egp html banner|**| -->


Stefan,<div class=3D""><br class=3D""></div><div class=3D"">Thank you for t=
he link. After a cursory glance, it seems like digging into Hamcrest to ass=
ert that an optional value is empty, for example, is more work for the user=
 than it=E2=80=99s worth. I would rather stick to David=E2=80=99s suggestio=
n of assertEquals(x, Optional.empty()) for this case, unless the assertion =
was especially complex. Then, as I mentioned to David, that isn=E2=80=99t n=
early as clean (in my opinion) as an assertEmpty would be.</div><div class=
=3D""><br class=3D""></div><div class=3D"">Best,</div><div class=3D"">Mark<=
/div><div class=3D""><br class=3D""></div><div class=3D""><br class=3D""><d=
iv><blockquote type=3D"cite" class=3D""><div class=3D"">On Oct 5, 2015, at =
12:18 AM, Stefan Bechtold <a href=3D"mailto:[email protected]" class=
=3D"">[email protected]</a> [junit] &lt;<a href=3D"mailto:junit@yahoog=
roups.com" class=3D"">[email protected]</a>&gt; wrote:</div><br class=
=3D"Apple-interchange-newline"><div class=3D""><div id=3D"ygrp-mlmsg" style=
=3D"font-size: 13px; font-family: Arial, helvetica, clean, sans-serif; font=
-style: normal; font-variant: normal; font-weight: normal; letter-spacing: =
normal; orphans: auto; text-align: start; text-indent: 0px; text-transform:=
 none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-s=
troke-width: 0px; background-color: rgb(255, 255, 255); position: relative;=
" class=3D""><div id=3D"ygrp-msg" style=3D"line-height: 1.22em; z-index: 1;=
" class=3D""><div id=3D"ygrp-text" style=3D"line-height: 1.22em; font-famil=
y: Georgia;" class=3D""><div style=3D"line-height: 1.22em; margin: 0px 0px =
1em;" class=3D""><br class=3D"webkit-block-placeholder"></div><div style=3D=
"line-height: 1.22em;" class=3D"">Hi Mark</div><div style=3D"line-height: 1=
.22em;" class=3D""><br style=3D"line-height: 1.22em;" class=3D""></div><div=
 style=3D"line-height: 1.22em;" class=3D"">Actually, I think this sounds mo=
re as an addition to a matcher framework like hamcrest rather than an addit=
ion to JUnit itself. What do you think?&nbsp;</div><div style=3D"line-heigh=
t: 1.22em;" class=3D""><br style=3D"line-height: 1.22em;" class=3D""></div>=
<div style=3D"line-height: 1.22em;" class=3D"">see also:&nbsp;<a href=3D"ht=
tps://github.com/hamcrest/JavaHamcrest/issues/82" style=3D"line-height: 1.2=
2em;" class=3D"">https://github.com/hamcrest/JavaHamcrest/issues/82</a></di=
v><div style=3D"line-height: 1.22em;" class=3D""><br style=3D"line-height: =
1.22em;" class=3D""></div><div style=3D"line-height: 1.22em;" class=3D"">al=
l the best</div><div style=3D"line-height: 1.22em;" class=3D""><br style=3D=
"line-height: 1.22em;" class=3D""></div><div style=3D"line-height: 1.22em;"=
 class=3D"">Stefan</div><div style=3D"line-height: 1.22em;" class=3D""><div=
 style=3D"line-height: 1.22em;" class=3D""><br style=3D"line-height: 1.22em=
;" class=3D""></div></div><div style=3D"line-height: 1.22em;" class=3D""><b=
r style=3D"line-height: 1.22em;" class=3D"">Am 04.10.2015 um 19:55 schrieb =
Mark Silvis<span class=3D"Apple-converted-space">&nbsp;</span><a href=3D"ma=
ilto:[email protected]" style=3D"line-height: 1.22em;" class=3D"">masilv=
[email protected]</a><span class=3D"Apple-converted-space">&nbsp;</span>[junit=
] &lt;<a href=3D"mailto:[email protected]" style=3D"line-height: 1.22em=
;" class=3D"">[email protected]</a>&gt;:<br style=3D"line-height: 1.22e=
m;" class=3D""><br style=3D"line-height: 1.22em;" class=3D""></div><blockqu=
ote type=3D"cite" style=3D"margin: 0px 0px 0px 4px; line-height: 1.22em;" c=
lass=3D""><div style=3D"line-height: 1.22em;" class=3D""><span style=3D"lin=
e-height: 1.22em;" class=3D"">&nbsp;</span><div id=3D"ygrp-text" style=3D"l=
ine-height: 1.22em; font-family: Georgia;" class=3D""><p style=3D"line-heig=
ht: 1.22em; margin: 0px 0px 1em;" class=3D"">I would like to contribute to =
JUnit, and I think I have a good idea for a feature. I=E2=80=99ve found tha=
t it would be nice to have assertions that explicitly supported Java 8=E2=
=80=99s Optional class. I=E2=80=99m thinking something along the lines of a=
ssertEmpty() and assertPresent(). Would such an addition be welcomed?<br st=
yle=3D"line-height: 1.22em;" class=3D""><br style=3D"line-height: 1.22em;" =
class=3D"">Thanks,<br style=3D"line-height: 1.22em;" class=3D"">Mark<br sty=
le=3D"line-height: 1.22em;" class=3D""></p></div></div></blockquote><div st=
yle=3D"line-height: 1.22em; margin: 0px 0px 1em;" class=3D""><br class=3D"w=
ebkit-block-placeholder"></div></div><div style=3D"line-height: 1.22em; col=
or: rgb(255, 255, 255); height: 0px;" class=3D""></div></div></blockquote><=
/div><br class=3D""></div>



<!-- |**|begin egp html banner|**| -->

<br>


<br>

<!-- |**|end egp html banner|**| -->


<div width=3D"1" style=3D"color: white; clear: both;"/>__._,_.___</div>

=20=20=20=20=20=20
=20=20

=20=20=20=20
    <div id=3D"fromDMARC" style=3D"clear:both; margin-top: 10px;">
         <hr style=3D"height:2px ; border-width:0; color:#E3E3E3; backgroun=
d-color:#E3E3E3;">
         Posted by: Mark Silvis &lt;[email protected]&gt;         <hr st=
yle=3D"height:2px ; border-width:0; color:#E3E3E3; background-color:#E3E3E3=
;">
    </div>
<!-- Start Recommendations -->
<!-- End Recommendations -->



<!-- |**|begin egp html banner|**| -->

  <img src=3D"http://geo.yahoo.com/serv?s=3D97476590/grpId=3D2423328/grpspI=
d=3D1705006905/msgId=3D24701/stime=3D1444048244" width=3D"1" height=3D"1"> =
<br>

<!-- |**|end egp html banner|**| -->

=20=20=20=20
<!-- |**|begin egp html banner|**| -->

<br>



=20=20=20
=20=20=20=20=20
=20
        <!-- |**|begin egp html banner|**| -->
        <div id=3D"ygrp-vital" style=3D"background-color: #f2f2f2; font-fam=
ily: Verdana; font-size: 10px; margin-bottom: 10px; padding: 10px;">

        <span id=3D"vithd" style=3D"font-weight: bold; color: #333; text-tr=
ansform: uppercase; "><a href=3D"https://groups.yahoo.com/neo/groups/junit/=
info;_ylc=3DX3oDMTJlaWhrcGFhBF9TAzk3MzU5NzE0BGdycElkAzI0MjMzMjgEZ3Jwc3BJZAM=
xNzA1MDA2OTA1BHNlYwN2dGwEc2xrA3ZnaHAEc3RpbWUDMTQ0NDA0ODI0NA--" style=3D"tex=
t-decoration: none;">Visit Your Group</a></span>

     <ul style=3D"list-style-type: none; margin: 0; padding: 0; display: in=
line;">
            <li style=3D"border-right: 1px solid #000; font-weight: 700; di=
splay: inline; padding: 0 5px; margin-left: 0;">
      <span class=3D"cat"><a href=3D"https://groups.yahoo.com/neo/groups/ju=
nit/members/all;_ylc=3DX3oDMTJmbGw3YjdiBF9TAzk3MzU5NzE0BGdycElkAzI0MjMzMjgE=
Z3Jwc3BJZAMxNzA1MDA2OTA1BHNlYwN2dGwEc2xrA3ZtYnJzBHN0aW1lAzE0NDQwNDgyNDQ-" s=
tyle=3D"text-decoration: none;">New Members</a></span>
      <span class=3D"ct" style=3D"color: #ff7900;">1</span>
    </li>
                                              </ul>
  </div>


<div id=3D"ft" style=3D"font-family: Arial; font-size: 11px; margin-top: 5p=
x; padding: 0 2px 0 0; clear: both;">
  <a href=3D"https://groups.yahoo.com/neo;_ylc=3DX3oDMTJkbTlna21sBF9TAzk3ND=
c2NTkwBGdycElkAzI0MjMzMjgEZ3Jwc3BJZAMxNzA1MDA2OTA1BHNlYwNmdHIEc2xrA2dmcARzd=
GltZQMxNDQ0MDQ4MjQ0" style=3D"float: left;"><img src=3D"http://l.yimg.com/r=
u/static/images/yg/img/email/new_logo/logo-groups-137x15.png" height=3D"15"=
 width=3D"137" alt=3D"Yahoo! Groups" style=3D"border: 0;"/></a>
  <div style=3D"color: #747575; float: right;"> &bull; <a href=3D"https://i=
nfo.yahoo.com/privacy/us/yahoo/groups/details.html" style=3D"text-decoratio=
n: none;">Privacy</a> &bull; <a href=3D"mailto:junit-unsubscribe@yahoogroup=
s.com?subject=3DUnsubscribe" style=3D"text-decoration: none;">Unsubscribe</=
a> &bull; <a href=3D"https://info.yahoo.com/legal/us/yahoo/utos/terms/" sty=
le=3D"text-decoration: none;">Terms of Use</a> </div>
</div>

<!-- |**|end egp html banner|**| -->

  </div> <!-- ygrp-msg -->

=20=20=20


  <br>

<!-- |**|end egp html banner|**| -->


<div style=3D"color: white; clear: both;"/>__,_._,___</div>
</body></html>
--Apple-Mail=_DC7312E4-F20E-477D-9E75-B9F9F4AD6C03--