Re: [ANN] 1.2.7 of Keel build system/Maven plugin released

Shash:

> >Hmm. Not sure if "minimal" can build a war - it's mean to have a
> >maven.uberjar.main, actually. (Run via CLI usually)
> >
> Got 1.2.8 of plugin built and installed locally.  Confirmed, I can build 
> minimal uberjar succesfully.

Ok - but you could not do this with 1.2.7?

> >>  In both projects, I get: 
> >>            [jar] Building jar:
> >>        C:\Users\Shash\Java\workspaces\keelapp\project\target\te
> >>        mp\keel-minimal-keel-config.jar
> >>            [java] java.lang.ArrayIndexOutOfBoundsException: 2
> >>            [java]      at KeelUberJar.main(KeelUberJar.java:69)
> >>            [java] Exception in thread "main"
> >>        
> >>        BUILD FAILED
> >>        File...... C:\Documents and
> >>        Settings\schatterjee\.maven\cache\maven-keel-plugin-
> >>        1.2.7\plugin.jelly
> >>        Element... java
> >>        Line...... 303
> >>        Column.... 61
> >>        Java returned: 1
> >>        Total time: 14 seconds
> >>        Finished at: Thu Mar 03 10:29:04 CST 2005
> >>In looking at plugin.jelly, could this be because the third argument
> >>to KeelUberJar is maven.uberjar.main, which for a webapp is
> >>undefined?  

Hmm - it should be OK for that third arg to be empty string, but
apparently for you it sees null, not empty string. I've just added an
"if" in the code to skip around that set, but it's confusing that I
didn't hit that here. Mind you, I haven't done my cross-platform tests
yet, so that might be it...

> >Mine blows up on the fact that no base.webapp is defined in minimal -
> >never gets as far as the uberjar (which it shouldn't, if there's no
> >maven.uberjar.main).
> >
> >If I put the maven.uberjar.main property back, though, and do a
> >keel:uberjar, it builds me a live one...
> >  
> >
> OK...I  can build the uberjar for minimal, but not the war for default.  
> Same error, with 1.2.8 of plugin.  In looking at KeelUberJar code in 
> line 69, it expects three aruments, but for a webapp 
> "maven.uberjar.main" is going to be empty.  Unless, I have a different 
> version of KeelUberJar.java than I should.  tool-config is version 3.0, 
> same as what is checked-in.

No, that's the latest - but I'll check one in that checks for the number
of params, as apparently it's *not* passing empty string like I thought
it was if the maven.uberjar.main is not set...

> >>A few other issues:
> >>
> >>- When I ran "maven keel:maven" (which I see exists  in plugin.jelly)
> >>in my project dir, I get:
> >>        $ maven keel:maven
> >>         __  __
> >>        |  \/  |__ _Apache__ ___
> >>        | |\/| / _` \ V / -_) ' \  ~ intelligent projects ~
> >>        |_|  |_\__,_|\_/\___|_||_|  v. 1.0.2
> >>        
> >>        BUILD FAILED
> >>        Goal "keel:maven" does not exist in this project.
> >>    
> >>
> >
> >Eh? This is very strange? Almost sounds like you need to re-install the
> >plugin. That goal is definitely there...
> >
> >  
> >
> This went away with 1.2.8...yes!!!!!

One down :-)

> 
> > Done. Actually, it's 1.2.8 now, due to a minor patch elsewhere, but
> >
> >essentially identical to 1.2.7.
> >
> >  
> >
> Got 1.2.8 of the plugin...but the project.xml in keel-build/ is still 
> 3.0...shouldn't it be 3.01?
> 
> >Thanks again for the feedback!
> >
> Sorry to be a pest!  Thanks for all the effort.  If I can get  the war 
> to build today, can we  get the  UI files moved to src/webapp ? 

Yes, in fact I already have the plugin including that dir when it does
it's thing. I may need to tell KeelUberJar to "skip" that pattern,
though.

>   I 
> failed miserably for the last two days to get svc-aop-aspectwerkz  
> resurrected after we did away  with the Keel  classloader magic.  I 
> think  I now want some positive feedback, so  maybe I'll give up on AW 
> for a bit and go and resurrect  clnt-velocity/webwork2/maverick.  But, 
> only makes sense to do  it after we  do away with special handling of  
> webapp/WEB-INF dirs.

Sorry, I'm sure my hacking at the classloader stuff is what broke
aspectwerkz! I thought I left in the critical bits, but apparently
not...

Thanks for the feedback and testing, we'll get this thing rock-solid
pretty soon!

Mike


http://keelframework.org/documentation.shtml
Keelgroup mailing list
[email protected]
http://lists.keelframework.com/listinfo.cgi/keelgroup-keelframework.com